Closed IuliiaHerets closed 2 weeks ago
Triggered auto assignment to @JmillsExpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
@mollfpr This issue is related to the following code:
In desktop the shouldSkipDeepLinkNavigation
is:
It is intentionally skipped due to this bug:
https://github.com/Expensify/App/issues/33149
When testing, I use the new-expensify:/aaa
instead of the usual address in the browser to open the desktop app.
I'm unsure if I should move the check after the onboarding logic due to this bug. I am creating a follow-up PR if we decide to move the check after the onboarding logic.
@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...
I think this is low priority, though I'll open it up to the community.
Job added to Upwork: https://www.upwork.com/jobs/~021836423410149372393
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External
)
@JmillsExpensify Since this issue from @tsa321 PR: https://github.com/Expensify/App/pull/48137, should we let them fix this?
It seems that PR #48955 has addressed this issue, so we can just close this here?
@JmillsExpensify @ntdiary this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
Nice, closing.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.31-12 Reproducible in staging?: Y Reproducible in production?: Y Issue was found when executing this PR: https://github.com/Expensify/App/pull/48137 Issue reported by: Applause Internal Team
Action Performed:
Precondition: use gmail NEW account.
Expected Result:
Desktop: the onboarding modal work page is displayed.
Actual Result:
Desktop: page not found is displayed
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/865730a0-93a0-4803-89c6-e93dc8f4a573
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ntdiary