Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.52k stars 2.87k forks source link

Copilot - Selected access level is not highlighted #48965

Closed IuliiaHerets closed 1 month ago

IuliiaHerets commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.32-0 Reproducible in staging?: Y Reproducible in production?: N/A Issue was found when executing this PR: https://github.com/Expensify/App/pull/47353 Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account settings > Security.
  3. Click Add copilot.
  4. Select a user.
  5. Select an access level.
  6. Click Access level on the confirmation page

Expected Result:

The selected access level will be highlighted.

Actual Result:

The selected access level is not highlighted.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/0fc53dcc-0b78-4542-9c80-8867adbb1866

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 1 month ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
mkzie2 commented 1 month ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

The selected access level is not highlighted.

What is the root cause of that problem?

We're missing initiallyFocusedOptionKey for this SelectionList:

https://github.com/Expensify/App/blob/7ff29a6235812bc6e1d60887fb3608b062e2491c/src/pages/settings/Security/AddDelegate/SelectDelegateRolePage.tsx#L41

What changes do you think we should make in order to solve the problem?

Add initiallyFocusedOptionKey={route.params.role}

rushatgabhane commented 1 month ago

not a blocker. @iwiznia @adelekennedy kindly assign it to me because im working on copilot project

melvin-bot[bot] commented 1 month ago

@dangrous, @rushatgabhane, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!