Closed IuliiaHerets closed 3 weeks ago
Triggered auto assignment to @RachCHopkins (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@RachCHopkins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Go to staging.new.expensify.com Login as copilot
I don't appear to be able to do this at all. I have tried multiple accounts with copilots and I don't have the drop-down.
@kadie is gonna repro for me.
Reproduced in web chrome:
https://github.com/user-attachments/assets/e1959f18-09f3-4b99-abaf-571699fb3b67
Job added to Upwork: https://www.upwork.com/jobs/~021834067418784580129
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External
)
Edited by proposal-police: This proposal was edited at 2024-09-12 03:46:19 UTC.
The RHP header is missing when confirming magic code for adding new contact method. Also, the message "Please enter the magic code sent to" is also missing the email.
We get the contact method by accessing account?.primaryLogin
. In the case of accessing account via Copilot, the account data doesn't have primaryLogin
field
We should use session data to get the email of the user
const [session] = useOnyx(ONYXKEYS.SESSION);
const contactMethod = session?.email ?? '';
const contactMethod = Object.keys(loginList ?? {}).find((login) => loginList?.[login]?.partnerUserID === login);
or if we want to default contact method we can find in the login list that the email is partnerUserID
or we can prevent user add new contact method if we can't access account?.primaryLogin
We also need to fix the other cases in that we use account?.primaryLogin
NA
Thanks for the proposal @nkdengineer
I believe we should use session?.email
only if account?.primaryLogin
is not available. What do you think?
const contactMethod = account?.primaryLogin ?? session?.email ?? '';
We also need to fix the other cases in that we use account?.primaryLogin
Could you please specify which other features or cases require changes involving the use of account?.primaryLogin
?
I believe we should use session?.email only if account?.primaryLogin is not available. What do you think?
@sobitneupane I think that makes sense. I think we can create a util for this and use in other places.
Could you please specify which other features or cases require changes involving the use of account?.primaryLogin?
I checked the use of account?.primaryLogin
in the App and see that we have some other places that we use this data.
Triggered auto assignment to @rafecolton, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Proposal LGTM, assigning @nkdengineer
📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Keep in mind: Code of Conduct | Contributing 📖
Approved the PR, waiting for a response here before merging.
PR is merged
@sobitneupane the automation has failed here, can I get you to do the checklist, please?
And I guess this will be ready to pay on 8 October.
Regression Test Proposal
Do we agree 👍 or 👎
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.43-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-10. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Contributor has been paid, the contract has been completed, and the Upwork post has been closed.
@RachCHopkins I will need payment summary to request payment in newdot.
Sorry @sobitneupane I didn't realise Melvin's summary was leaving that out!
Payment Summary:
Upwork job here
$250 approved for @sobitneupane
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.32-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The RHP header will show the current contact method.
Actual Result:
The RHP header is missing when confirming magic code for adding new contact method. Also, the message "Please enter the magic code sent to" is also missing the email.
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/13793b42-b666-462f-abfd-61f37ff10dba
https://github.com/user-attachments/assets/91527319-07f0-4b56-8c85-84591231b31a
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @RachCHopkins