Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[Pending / Scanning] Message containing a report says it is from the workspace name instead of the cardholder's name #49036

Open m-natarajan opened 5 days ago

m-natarajan commented 5 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @kevinksullivan Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726081403491199

Action Performed:

  1. Get assigned a >$0 limit on cardtest.expensify.com domain
  2. Navigate to NewDot in your test account, and go to Settings > Wallet > Expensify Card > Reveal details (on virtual card)
  3. Navigate to this paypal link and select “buy” on the first button on that screen, and use your virtual card details to make the purchase.
  4. Check workspace chat

Expected Result:

Cardholder's name displayed in report

Actual Result:

Message containing a report says it is from the workspace name. Same issue observed for IOUs as well

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

image (7)

image (8)

Add any screenshot/video evidence

View all open jobs on GitHub

melvin-bot[bot] commented 5 days ago

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

MelvinBot commented 5 days ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

kevinksullivan commented 5 days ago

Discussing broader expected behavior here

https://expensify.slack.com/archives/C036QM0SLJK/p1726064302069299

grgia commented 4 days ago
grgia commented 4 days ago

Pasting from slack:

Seems the issue might is from this line here, which is causing the second part of this line to always be true

 const isWorkspaceActor = isInvoiceReport || (ReportUtils.isPolicyExpenseChat(report) && (!actorAccountID || displayAllActors));
grgia commented 4 days ago

https://github.com/Expensify/App/blob/main/src/libs/ReportUtils.ts#L7463-L7464

grgia commented 4 days ago

The actor account ID in onyx is correct, but we're using the wrong data here

grgia commented 1 day ago

https://www.figma.com/design/qQIIaxVUdtggrh8eg8bI5B/Brand-Guidelines-%26-Product-UI?node-id=10519-54496&t=lpYB1Q5Xz7YQzEYW-4