Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

Company cards - AMEX icon is cut off on Android and iOS app #49047

Closed IuliiaHerets closed 5 days ago

IuliiaHerets commented 5 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.33-1 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Issue was found when executing this PR: https://github.com/Expensify/App/pull/48119 Email or phone of affected tester (no customers): applausetester+kh090901@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  1. Launch New Expensify app.
  2. Go to https://staging.new.expensify.com/settings/workspaces/policyID/company-cards/add-card-feed

Expected Result:

AMEX icon will be displayed in full card (web behavior).

Actual Result:

AMEX icon is cut off on Android and iOS app.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/08f62304-0068-4263-ac67-a80aa442fb3d

View all open jobs on GitHub

melvin-bot[bot] commented 5 days ago

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 5 days ago

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 5 days ago

We think that this bug might be related to #wave-control

github-actions[bot] commented 5 days ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
Pujan92 commented 5 days ago

I think company card feature is not opened for QA yet, this will be handled by @waterim

waterim commented 5 days ago

@joekaufmanexpensify Should it be closed as Company cards is under NO QA label?

koko57 commented 5 days ago
joekaufmanexpensify commented 5 days ago

Yeah, let's close for now. This feature is still in implementation. We're going to start comprehensive manual testing soon, but any QA now is premature.