Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[$250] Search - Domain room chat is missing in "In" list #49055

Closed IuliiaHerets closed 6 days ago

IuliiaHerets commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.33-1 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  1. Go to staging.new.expensify.com
  2. Go to domain room chat #applause.expensifail.com
  3. Send a message.
  4. Go to Search > Chats.
  5. Click Filters.
  6. Click In.
  7. Look for the domain room chat.

Expected Result:

The domain room chat should be in the list.

Actual Result:

The domain room chat is missing in "In" list.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/2b884e0e-df34-4350-a09b-c96ff27637ba

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021834269100709626401
  • Upwork Job ID: 1834269100709626401
  • Last Price Increase: 2024-09-12
Issue OwnerCurrent Issue Owner: @ZhenjaHorbach
melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
Julesssss commented 1 week ago

new feature, doesn't exist in prod

Removing blocker .

melvin-bot[bot] commented 6 days ago

Job added to Upwork: https://www.upwork.com/jobs/~021834269100709626401

melvin-bot[bot] commented 6 days ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

NaveedShaikh78 commented 6 days ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - Domain room chat is missing in "In" list .

What is the root cause of that problem?

The '#' key is not present in room name. Hence it is not matching.

What changes do you think we should make in order to solve the problem?

Searching should not be depend on exact match it should allow up to 80% to 90 % match even with some spelling mistake.

What alternative solutions did you explore? (Optional)

ZhenjaHorbach commented 6 days ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - Domain room chat is missing in "In" list .

What is the root cause of that problem?

The '#' key is not present in room name. Hence it is not matching.

What changes do you think we should make in order to solve the problem?

Searching should not be depend on exact match it should allow up to 80% to 90 % match even with some spelling mistake.

What alternative solutions did you explore? (Optional)

@NaveedShaikh78 Thanks for your proposal ! But your proposal sounds too abstract Can you provide the proposal with code examples please?

Julesssss commented 6 days ago

On second thoughts I believe this is expected. We are also working on major changes to search, so I am closing.