search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.53k stars 2.88k forks source link

Sage Intacct - Able to connect to Sage Intacct without upgrading to control policy #49057

Closed IuliiaHerets closed 1 month ago

IuliiaHerets commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.33-1 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+shsb22qqwww@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Log into newdot app
  2. Navigate to settings > workspace > create new workspace
  3. Go to more features > enable accounting
  4. Navigate to the accounting page > Connect to Sage Intacct
  5. When the modal to upgrade the workspace to control appears, dismiss it by clicking on back button

Expected Result:

RHP closes and user is not able to proceed with Sage Intacct connection

Actual Result:

The upgrade modal is dismissed and the app proceeds to Sage Intacct connection and user is able to connect while still in a collect policy

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/d98f7e61-fc34-4e6c-b453-faec4c6f39d2

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 1 month ago

We think that this bug might be related to #wave-control

github-actions[bot] commented 1 month ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
shubham1206agra commented 1 month ago

Offending PR https://github.com/Expensify/App/pull/48673

rlinoz commented 1 month ago

Offending PR https://github.com/Expensify/App/pull/48673

I confirmed it locally, thanks!

melvin-bot[bot] commented 1 month ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

rayane-djouah commented 1 month ago

The PR fixes the above bug as well 👍

luacmartins commented 1 month ago

This is fixed on staging

luacmartins commented 1 month ago

No payments due since this was a regression. Closing.