[Held] [$250] Invoices - Workspace settings can be opened from "workspace" link when workspace is deleted

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.33-1 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Issue was found when executing this PR: https://github.com/Expensify/App/pull/48275 Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• User B has no workspace.

1. Go to staging.new.expensify.com
2. {User A] Send an invoice to User B.
3. [User B] Pay the invoice using Pay as a business option.
4. [User B] Delete the workspace.
5. {User B] Go to invoice chat.
6. [User B] Click on the "workspace" link in Expensify message.

Expected Result:

The link should lead to not here page because workspace is deleted.

Actual Result:

The link can open workspace settings page and Members tab leads to not here page.

Workaround:

Unknown

Platforms:

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/a1540862-f566-4c88-b999-caf2bdf3094f

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021834598579747458653
• Upwork Job ID: 1834598579747458653
• Last Price Increase: 2024-09-13
• Automatic offers:
• ishpaul777 | Contributor | 104008088
• gijoe0295 | Contributor | 104027162

Issue Owner

Current Issue Owner: @ntdiary

[melvin-bot[bot]]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #vip-bills

[iwiznia]

Removed blocker, see https://expensify.slack.com/archives/C9YU7BX5M/p1726158576447559

[melvin-bot[bot]]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[luacmartins]

@IuliiaHerets I think the uploaded video is incorrect. Can you please check?

[IuliiaHerets]

@luacmartins fixed, sorry for this

[luacmartins]

No problem. Thank you!

[luacmartins]

This is also reproducible in prod if we just copy/paste the workspace link

[rlinoz]

Just by having the workspace link in any chat the problem also happens in prod:

https://github.com/user-attachments/assets/778e2117-0eb4-47b8-9f49-6da855676b88

[IuliiaHerets]

We can't pay the invoice using Pay as a business in prod, so I marked it as N/A - can't check on prod

[gijoe0295]

Edited by proposal-police: This proposal was edited at 2023-10-06T15:00:00Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The link can open workspace settings page and Members tab leads to not here page.

What is the root cause of that problem?

After deleting the workspace, we still retain some workspace information to show the invoice report's avatars and name:

These information is returned by OpenReport:

The not found page condition here simply checks for empty/delete-pending policy:

https://github.com/Expensify/App/blob/c6ce0f80c52457759ca4e3534c2393b9240aa48d/src/pages/workspace/WorkspacePageWithSections.tsx#L171-L174

What changes do you think we should make in order to solve the problem?

1. We can add shouldShowPolicy to the shouldShowNotFoundPage above to filter these workspaces and prevent them from being accessed by URL:

https://github.com/Expensify/App/blob/7748eff72fc43ecaf3db6159928d8d581a63ab99/src/libs/PolicyUtils.ts#L180-L187

This condition is also used in WorkspacesListPage to filter viewable workspace. This solution ensures if a workspace did not appear in the workspaces list, it should not be accessible via direct URL.

https://github.com/Expensify/App/blob/0c37d5b3e3d837deb17f526ed7dff94d8ce36fa4/src/pages/workspace/WorkspacesListPage.tsx#L315

2. We also need to add the above filter to WorkspaceInitialPage and WorkspaceProfilePage:

https://github.com/Expensify/App/blob/c2257714c5dbf58f3f61883d115496e6728a1dd9/src/pages/workspace/WorkspaceInitialPage.tsx#L310

https://github.com/Expensify/App/blob/1eecd00ad95753d8b6e0ea066fd12be62f56c3aa/src/pages/workspace/WorkspaceProfilePage.tsx#L155

3. And modify the not found subtitle in those pages as well since they are assuming that only empty policies are deleted:

https://github.com/Expensify/App/blob/c6ce0f80c52457759ca4e3534c2393b9240aa48d/src/pages/workspace/WorkspacePageWithSections.tsx#L190

https://github.com/Expensify/App/blob/c2257714c5dbf58f3f61883d115496e6728a1dd9/src/pages/workspace/WorkspaceInitialPage.tsx#L363

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021834598579747458653

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The link can open the workspace settings page and Members tab leads to not here page.

What is the root cause of that problem?

After the user deletes the workspace, the policy data still exists then the not found page doesn't display because this check doesn't cover full case like we did here

https://github.com/Expensify/App/blob/14b5ccc38534683a4d96460ee5266732a65f3b0a/src/pages/workspace/WorkspacePageWithSections.tsx#L164-L170

What changes do you think we should make in order to solve the problem?

We should use the same check as we did here in shouldShow here then that can fix for all policy pages

const shouldShowPolicy = useMemo(() => {
    return PolicyUtils.shouldShowPolicy(policy, isOffline, session?.email);
}, [policy, isOffline, session?.email]);

const prevShouldShowPolicy = useMemo(() => {
    return PolicyUtils.shouldShowPolicy(prevPolicy, isOffline, session?.email);
}, [prevPolicy, isOffline, session?.email]);

const shouldShow = useMemo(() => {
    // If the policy object doesn't exist or contains only error data, we shouldn't display it.
    if (((isEmptyObject(policy) || (Object.keys(policy).length === 1 && !isEmptyObject(policy.errors))) && isEmptyObject(policyDraft)) || shouldShowNotFoundPage) {
        return true;
    }

    // We check isPendingDelete for both policy and prevPolicy to prevent the NotFound view from showing right after we delete the workspace
    return (!isEmptyObject(policy) && !PolicyUtils.isPolicyAdmin(policy) && !shouldShowNonAdmin) || (!shouldShowPolicy && !prevShouldShowPolicy);
    // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
}, [policy, shouldShowNonAdmin, shouldShowPolicy, prevShouldShowPolicy]);

https://github.com/Expensify/App/blob/14b5ccc38534683a4d96460ee5266732a65f3b0a/src/pages/workspace/WorkspacePageWithSections.tsx#L164-L170

Then we can update the condition here like this to display the correct subtitle

shouldShowPolicy ?  'workspace.common.notAuthorized' : undefined

https://github.com/Expensify/App/blob/b69577a55bc536a411d8c1e51fc47fc0fc00d389/src/pages/workspace/WorkspacePageWithSections.tsx#L190

We can do the same fix for WorkspaceInitialPage https://github.com/Expensify/App/blob/b69577a55bc536a411d8c1e51fc47fc0fc00d389/src/pages/workspace/WorkspaceInitialPage.tsx#L310

What alternative solutions did you explore? (Optional)

We can fix this from BE side that will not return the data of deleted policy

[joekaufmanexpensify]

Pending review of proposal

[melvin-bot[bot]]

@ntdiary, @srikarparsi, @joekaufmanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[joekaufmanexpensify]

@ntdiary can you review proposals here?

[ntdiary]

@ntdiary can you review proposals here?

Ah, @joekaufmanexpensify, sorry, under review. I missed this issue. 😅

[allgandalf]

Taking over this issue (slack), can you please assign me here @joekaufmanexpensify @srikarparsi

[joekaufmanexpensify]

We ended up rolling the dice for this one since there was a lot of interest, and @ishpaul777 was selected, so going with them!

[melvin-bot[bot]]

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[joekaufmanexpensify]

Pending @ishpaul777 review of proposals

[ishpaul777]

Looking 👀

[ishpaul777]

@nkdengineer I dont understand the usage for prevShouldShowPolicy in your proposal could you clarify the usage please ?

[nkdengineer]

PolicyUtils.isPendingDeletePolicy(policy) && PolicyUtils.isPendingDeletePolicy(prevPolicy)

@ishpaul777 Here is the old condition and we should replace it with shouldShowPolicy function. That is why we have prevShouldShowPolicy variable. I create a new variable because we need to use shouldShowPolicy to display the correct subtitle.

subtitleKey={isEmptyObject(policy) ? undefined : 'workspace.common.notAuthorized'}

[ishpaul777]

Thanks for clarifying @nkdengineer. 👍

---

I dont think there are any major difference between @nkdengineer solution and @gijoe0295's solution, since @gijoe0295 Proposed this first lets assign them

🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Current assignee @srikarparsi is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot[bot]]

📣 @gijoe0295 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[joekaufmanexpensify]

@gijoe0295 is there an ETA for PR here?

[gijoe0295]

Will complete in 5 hours.

[joekaufmanexpensify]

PR in review

[joekaufmanexpensify]

PR still in review

[ishpaul777]

Still in review, found a bug that is taking sometime to fix, @gijoe0295 is still looking into it

[joekaufmanexpensify]

Sounds good!

[joekaufmanexpensify]

PR still in review

[joekaufmanexpensify]

This one's now held for https://github.com/Expensify/react-native-onyx/pull/588 , we'll finish up the PR once that's out.

[joekaufmanexpensify]

@ishpaul777 @srikarparsi I see the above PR was merged and published. Can we take this off hold now?

[ishpaul777]

yeah i have asked @gijoe0295 to retest and confirm few days back https://github.com/Expensify/App/pull/49509#issuecomment-2450831699

[joekaufmanexpensify]

Great. TY!

[gijoe0295]

Will retest today.

[joekaufmanexpensify]

@gijoe0295 Did you have a chance to do this?

[ishpaul777]

@gijoe0295 has asked some help from @fabioh8010, the investigation in ongoing https://github.com/Expensify/App/pull/49509

[joekaufmanexpensify]

Sounds good. TY!