Open IuliiaHerets opened 2 weeks ago
Triggered auto assignment to @dylanexpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
We think that this bug might be related to #vip-bills
@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
The invoice room is not archived after deleting the workspace offline.
When deleting workspaces, we choose what report to be archived here: https://github.com/Expensify/App/blob/7748eff72fc43ecaf3db6159928d8d581a63ab99/src/libs/actions/Policy/Policy.ts#L312-L314
However, an invoice sent from user A will have policyID
of A's WS, not of B's WS, so the condition report?.policyID === policyID
is false
, hence the chat room not archived.
We should add logic to include invoice chat sent from others as well, like what we did here
Update this:
to:
(report) =>
(report?.policyID === policyID || (report?.invoiceReceiver && 'policyID' in report?.invoiceReceiver && report?.invoiceReceiver.policyID == policyID)) &&
(ReportUtils.isChatRoom(report) || ReportUtils.isPolicyExpenseChat(report) || ReportUtils.isTaskReport(report)),
@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?
reviewing today!
@dylanexpensify Eep! 4 days overdue now. Issues have feelings too...
@davidcardoza can you confirm if this is unexpected behavior?
Do we archive workspace rooms after a workspace is delete? If yes, an invoice room should follow the same pattern.
@dylanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.33-1 Reproducible in staging?: Y Reproducible in production?: Y Issue was found when executing this PR: https://github.com/Expensify/App/pull/48275 Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Expected Result:
The invoice chat should be archived after deleting the workspace offline.
Actual Result:
The invoice room is not archived after deleting the workspace offline.
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/e0fa69f8-afee-487e-b4c4-737ceae9df5a
Add any screenshot/video evidence
View all open jobs on GitHub