[$250] [Awaiting Payment] Close reports for the combo of Instant Submit + No Approvals + No Payments

garrettmknight commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: N/A Reproducible in staging?: Y Reproducible in production?: Y Issue reported by: @garrettmknight Slack conversation: https://expensify.slack.com/archives/C06ML6X0W9L/p1726136887331749?thread_ts=1725892977.799399&cid=C06ML6X0W9L

Action Performed:

Sign up with a new account
Select 'Manage my team's expenses'
Enter a first name
Enable Workflows in the workspace
Navigate to the Workflows tab
Disable Payments
Navigate to your workspace chat
Submit a manual expense

Expected Result:

Since there is no approval or payment action for anyone to take, the report should be Closed. This will result in each individual expense in this configuration creating a closed report.

Actual Result:

The expense is added to a report in the Processing state with inaccurate next steps: Waiting for [workspace admin] to pay expense(s).

Workaround:

No workaround.

Platform:

All

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021848799022838902607
Upwork Job ID: 1848799022838902607
Last Price Increase: 2024-10-22

Issue Owner

Current Issue Owner: @garrettmknight

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

trjExpensify commented 1 month ago

Because of a couple of other bugs atm we're working on elsewhere, you might want to switch to OldDot settings to get your workspace into the correct state to develop with @srikarparsi, or basically these are the three important properties on the workspace for the right condition:

scheduledSubmit=instantly
approvals = submit & close (can't remember what this one is technically, APPROVAL_MANUAL maybe 😅)
reimbursement=none

srikarparsi commented 1 month ago

Awesome, I was able to replicate this pretty easily using @garrettmknight's steps in the issue body, didn't have to do anything in Old Dot. We just don't want the "Waiting for Srikar to pay expense(s)" because payments is not enabled right.

trjExpensify commented 1 month ago

Awesome, I was able to replicate this pretty easily using @garrettmknight's steps in the issue body

Ah yeah, I mean it's impossible in NewDot to get the workspace into that state because of the bugs. So if you need to to test what happens to the report state when all of those three are set as such, you can get the config there via OldDot.

We just don't want the "Waiting for Srikar to pay expense(s)" because payments is not enabled right.

I think you've figured out since that the nextSteps text isn't the only scope of what's wrong with this issue. The underlying report is in the processing state instead of closed when "instant + no approvals + no payments" is configured.

shubham1206agra commented 1 month ago

@garrettmknight Can you assign me this issue as reviewer?

melvin-bot[bot] commented 2 weeks ago

This issue has not been updated in over 15 days. @garrettmknight, @srikarparsi, @shubham1206agra eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

shubham1206agra commented 2 weeks ago

@trjExpensify Can you start payment here?

trjExpensify commented 2 weeks ago

I can slap some nagging labels on for @garrettmknight. 😏

melvin-bot[bot] commented 1 week ago

Job added to Upwork: https://www.upwork.com/jobs/~021848799022838902607

melvin-bot[bot] commented 1 week ago

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

garrettmknight commented 1 week ago

@shubham1206agra offer is out to you.

garrettmknight commented 1 week ago

https://www.upwork.com/ab/applicants/1848799022838902607/hired

garrettmknight commented 1 week ago

Paid!

melvin-bot[bot] commented 1 week ago

@garrettmknight @srikarparsi Be sure to fill out the Contact List!

tgolen commented 1 week ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x] [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: N/A this has always been this way, this is more of a NewFeature than anything.
[x] [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[x] [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[x] [@shubham1206agra] Determine if we should create a regression test for this bug.
[x] [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[x] [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

garrettmknight commented 1 week ago

Took care of the checklist since it's a bit more of a New Feature issue.

melvin-bot[bot] commented 1 week ago

@garrettmknight @srikarparsi Be sure to fill out the Contact List!

Expensify / App