Closed arosiclair closed 4 weeks ago
Triggered auto assignment to @muttmuure (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
We did some troubleshooting in slack here, but no solutions found yet. cc @Julesssss
At a minimum, we're missing instructions on adding Mobile-Expensify/react-native/.env
. But even adding that doesn't fix the issue.
@staszekscp @war-in @AndrewGable it sounds like you guys are the only ones successfully running the HybridApp. Can any of you take a look? Ideally, we should be able to just clone Mobile-Expensify
, follow the instructions and be good to go for HybridApp dev.
@mateuuszzzzz noticed today that the react-native submode commit was outdated. This should be the breakthrough we were hoping for 🎉
Submodule commit bump should resolve the issue👌
Just noting there is an outstanding issue with live-markdown
, so engineers need to checkout the prior commit within react-native: d5cfecfc53a
16415328f9462eb4e9a8cd0099833d29948f1544
Bump to @Julesssss comment
Developers should use ND (submodule) with 16415328f9462eb4e9a8cd0099833d29948f1544
commit
https://github.com/Expensify/Mobile-Expensify/pull/13122 Should fix the issue
I don't think this is done. Has anyone completed the repro steps and confirmed the new experience loads? It doesn't look like it from the PR we just merged or the slack conversation. We also haven't updated the HybridApp instructions to include steps for adding a .env
.
@arosiclair nope, thanks for calling this out.
This morning I switched my local builds to the latest commit and will report back.
Hi 👋 @arosiclair I went through the reproduction steps and I can confirm the issue with infinite bootsplash is fixed (it works fine for me). That's why I suggested to close the issue
However, I noticed a few inconveniences while setting up the repo. This is the list:
main.jsbundle.map
file is not created automatically for the Debug
build which results in a failing build
Release
build firstnpm run ios
command
Thoughts:
main.jsbundle.map
issue should be fixed.env
configurationPlease share your thoughts too and let me know if the infinite bootsplash issue is gone 🙏
cc @arosiclair @Julesssss
I can confirm the bootsplash issue is resolved for me (at least, on production env builds).
Just tested with npm run ios
and it worked with the latest changes. I did have to kill and then relaunch the app to get it to connect to Metro. That has also been an issue with NewDot standalone so I think we can do nothing for that issue.
Thoughts:
- the build commands should be updated/repaired
- the main.jsbundle.map issue should be fixed
- README should contain more details on troubleshooting a .env configuration
Agreed 👍. I'll post a PR to add instructions on the .env
Agreed 👍. I'll post a PR to add instructions on the .env
Amazing, thank you!
You can also be interested in this PR where @mateuuszzzzz is adding .env
configuration into HybridApp
@grgia, @muttmuure, @mateuuszzzzz Whoops! This issue is 2 days overdue. Let's get this updated quick!
@grgia, @muttmuure, @mateuuszzzzz 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
PR is code complete but held atm
@arosiclair, @grgia, @muttmuure, @mateuuszzzzz Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Still held
@arosiclair, @grgia, @muttmuure, @mateuuszzzzz Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
README updates are in this is all done.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: N/A Reproducible in staging?: N/A Reproducible in production?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): N/A Logs: N/A Expensify/Expensify Issue URL: N/A Issue reported by: @arosiclair Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1726157922153189
Action Performed:
Expected Result:
The app loads and shows the new experience LHN
Actual Result:
The boot splash shows and never disappears
Workaround:
None
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
View all open jobs on GitHub