search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.52k stars 2.87k forks source link

[$250] New draft reports and additional expenses added to a draft report will not mark a workspace chat unread #49184

Closed garrettmknight closed 3 weeks ago

garrettmknight commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: N/A Reproducible in staging?: Y Reproducible in production?: Y Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @coleaeason Slack conversation: https://expensify.slack.com/archives/C06ML6X0W9L/p1725978630280069?thread_ts=1725864497.268339&cid=C06ML6X0W9L

Action Performed:

  1. Create a workspace
  2. Invite a submitter and approver
  3. Enable approvals setting approver
  4. Enable Delay submissions
  5. As the approver, navigate to the submitter's workspace chat and mark as read if it's unread + navigate to another chat
  6. Create an expense as the submitter

Expected Result:

The Submitter's workspace chat is not unread when they create a new draft report.

Actual Result:

The submitter's workspace chat is marked unread when they create a new draft report.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

All

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021834641825011202120
  • Upwork Job ID: 1834641825011202120
  • Last Price Increase: 2024-10-11
Issue OwnerCurrent Issue Owner: @ishpaul777
melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~021834641825011202120

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

FitseTLT commented 1 month ago

@garrettmknight Can you upload a vid? It isn't clear. I see it gets unread for the first expense the submitter creates but for the second expense of course it doesn't get unread as for the second expense a report action will only be created for the iou report; not to the workspace chat because until the report is submitted the expenses will be inserted in to the same expense report.

sandipanghos commented 1 month ago

@garrettmknight @FitseTLT can you confirm if as per the business the expense on draft report should be in read state?

ishpaul777 commented 1 month ago

i'll try to reproduce this today

puneetlath commented 1 month ago

I would think this probably also needs a back-end update. That we'll need to update how this works optimistically, but also from the back-end.

FitseTLT commented 1 month ago

@puneetlath I need an answer here as it can potentially be a dupe.

ishpaul777 commented 1 month ago

Looks very similar to https://github.com/Expensify/App/issues/37315, @puneetlath @garrettmknight Is it possible to get the videos/screenshot for this

garrettmknight commented 1 month ago

I think it's a bit different: https://github.com/user-attachments/assets/ad67cd5d-da88-4a8b-b86a-462203bad820

garrettmknight commented 1 month ago

Just confirmed that additional expenses don't mark unread, it's just new draft reports. Updating OP.

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

ishpaul777 commented 1 month ago

We are looking for proposals :

FitseTLT commented 1 month ago

The expected result is illogical our current behaviour is the correct one because users should be informed, by marking the workspace chat unread, that there is a new draft report.

VictoriaExpensify commented 1 month ago

@FitseTLT I think the issue is that the Workspace chat should be shown as Unread when there is new information/messages the user is not aware of. As the creator of the expense, the submitter's workspace chat does not need to be marked as unread because there is nothing they need to be notified of.

@garrettmknight please correct me if I have that wrong

VictoriaExpensify commented 1 month ago

Not overdue

ishpaul777 commented 1 month ago

not overdue, awaiting proposals

FitseTLT commented 1 month ago

@FitseTLT I think the issue is that the Workspace chat should be shown as Unread when there is new information/messages the user is not aware of. As the creator of the expense, the submitter's workspace chat does not need to be marked as unread because there is nothing they need to be notified of.

@garrettmknight please correct me if I have that wrong

@VictoriaExpensify It is confusing. From the OP, it seems the expected result is from the approver's side and what I am opposing is making the workspace chat as read from the approver's side. But if the OP is for the submitter's side it is the current behaviour of the app as it will open the workspace chat when you submit the expense it is not unread. I think it would be very helpful if we can upload a video in the OP. @garrettmknight

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 1 month ago

@VictoriaExpensify @ishpaul777 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 1 month ago

@VictoriaExpensify, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

ishpaul777 commented 1 month ago

We are waiting for proposals

melvin-bot[bot] commented 1 month ago

@VictoriaExpensify, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 1 month ago

@VictoriaExpensify, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

ishpaul777 commented 1 month ago

We dont have any proposals melvin, we are waiting for proposals

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

ishpaul777 commented 1 month ago

bumped in slack

JKobrynski commented 4 weeks ago

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

melvin-bot[bot] commented 4 weeks ago

@VictoriaExpensify, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

trjExpensify commented 4 weeks ago

@jasperhuangg I think this issue will get swallowed up by the proposed changes to the unread summary handling and what not. Do you want to take this over? close it and handle it elsewhere? or provide more direction on what we want to do in this issue, so it's not conflicting the plan?

ishpaul777 commented 4 weeks ago

not overdue, Callstack member will look into this one and we are also pulling Jasper for some direction on this issue

JKobrynski commented 3 weeks ago

The reason this happens is because even though there is a draft "comment" (expense) in the report, the reportDraftComment_<id> Onyx key is empty. I will continue my investigation to find out why that's the case. It might be a missing backend update, but I will have to confirm it.

melvin-bot[bot] commented 3 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

jasperhuangg commented 3 weeks ago

I think this issue will get swallowed up by the proposed changes to the unread summary handling and what not. Do you want to take this over? close it and handle it elsewhere? or provide more direction on what we want to do in this issue, so it's not conflicting the plan?

I think we probably just shouldn't tackle this right now since it seems like whatever we do here could wind up getting undone by the expense submission notification improvements project.