Open IuliiaHerets opened 5 days ago
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Triggered auto assignment to @puneetlath (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Triggered auto assignment to @puneetlath (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
We think that this bug might be related to #wave-control
Edited by proposal-police: This proposal was edited at 2023-10-04T16:20:00Z.
shouldRenderTooltip
is true, it's true for every items:NVP_SHOULD_HIDE_SAVED_SEARCH_RENAME_TOOLTIP
is a local value and gets clear out once signing out.index
param to createSavedSearchMenuItem
and only show tooltip for the first item:shouldRenderTooltip: index === 0 && !shouldHideSavedSearchRenameTooltip
NVP_SHOULD_HIDE_SAVED_SEARCH_RENAME_TOOLTIP
just like we did here:This is known and NAB for now. We're addressing it as a follow up.
Also to be solved:
The tooltip should not show over a dialog.
Steps:
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.35-0 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Issue was found when executing this PR: https://github.com/Expensify/App/pull/48566 Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
Educational tooltip will not appear again as it has appeared previously.
Actual Result:
Educational tooltip appears repeatedly for each saved search after relogin.
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/3f7d9f4c-5722-428e-a480-9ba7306d421d
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @lakchote