search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[Search v2.3] - Same saved search can be created at most twice #49205

Open IuliiaHerets opened 5 days ago

IuliiaHerets commented 5 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.35-0 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Search.
  3. Click Filters.
  4. Select Merchant and add search query (issue is reproducible with Merchant filter and not Date, Total filter).
  5. Click Save search.
  6. Click 3-dot menu next to the saved search > Rename.
  7. Enter a custom name and save it.
  8. Click Filters > Save search.
  9. Note that it creates another saved search.
  10. Rename the second saved search.
  11. Go back to the first saved search.
  12. Click Filters > Save search.
  13. Note that it does not create a new search but changes the name of second saved search back to default.

Expected Result:

In Step 9, it will not create another same saved search because the filters are not modified.

Actual Result:

In Step 9, it creates another same saved search when the filters are not modified.

If Step 9 is the correct behavior, Step 13 shows a different result because user cannot create the same third saved from the first saved search as it changes the name of second saved search back to default.

This issue is not reproducible when Date and Total filter are used.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/46e041c2-abf9-4dd0-a0a5-1c22a85ce0be

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @lakchote
melvin-bot[bot] commented 5 days ago

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 5 days ago

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 5 days ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
luacmartins commented 4 days ago

This is coming from this PR. Gonna demote it to NAB, since it's not breaking any functionality. @lakchote we need to figure out why the hashes are different in this case.