Closed IuliiaHerets closed 1 day ago
Triggered auto assignment to @trjExpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Triggered auto assignment to @neil-marcellini (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Edited by proposal-police: This proposal was edited at 2024-09-14 21:40:49 UTC.
Saved search - Long list causes overlap with status bar on native, and unscrollable on mweb
In https://github.com/Expensify/App/commit/c04e7a1f2e4b0d04c935aafd8cf44c10b7a7ce0f, we added a scrollview in PopoverMenu to make it scrollable, but height for menu is not capped, so it can go beyond the screen height and overlap with status bar on native, and be unscrollable on mweb
we need to set a max height for the menu so it doesn't go beyond the screen height. (we'll add this in a new style), we'll also need to confirm the upper margin value from design team. for now, its 200 as a placeholder.
const {windowHeight} = useWindowDimensions();
<ScrollView style={isSmallScreenWidth ? {maxHeight: windowHeight - 200} : createMenuContainer}>
https://github.com/user-attachments/assets/a67da04d-03ac-4c82-b60b-40072c585bed
https://github.com/user-attachments/assets/bdc3fa5a-8c44-4540-8a29-91c317492616
@lakchote will address this in a follow up from his PR
Fixed on staging.
Reopening to compensate @ishpaul777 $50 since his solution was used to solve this issue.
⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.
Offer sent to Ishpaul for $50 for the proposal.
Paid!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.35-0 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Expected Result:
In Step 4, the selected Expenses tab will not overlap with the status bar. In Step 8, the list is scrollable on mobile web.
Actual Result:
In Step 4, the selected Expenses tab overlaps with the status bar. In Step 8, the list is not scrollable on mobile web.
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/cfd6bea5-28dc-4e7a-9fc6-80db46a42bed
View all open jobs on GitHub