Open IuliiaHerets opened 1 month ago
Triggered auto assignment to @Beamanator (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
Triggered auto assignment to @anmurali (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
We need to preserve the scroll position after choosing any saved search option.
To do it, in here, add:
const route = useRoute();
const scrollViewRef = useRef<RNScrollView>(null);
const {saveScrollOffset, getScrollOffset} = useContext(ScrollOffsetContext);
const onScroll = useCallback<NonNullable<ScrollViewProps['onScroll']>>(
(e) => {
// If the layout measurement is 0, it means the flashlist is not displayed but the onScroll may be triggered with offset value 0.
// We should ignore this case.
if (e.nativeEvent.layoutMeasurement.height === 0) {
return;
}
saveScrollOffset(route, e.nativeEvent.contentOffset.y);
},
[route, saveScrollOffset],
);
useLayoutEffect(() => {
const scrollOffset = getScrollOffset(route);
if (!scrollOffset || !scrollViewRef.current) {
return;
}
scrollViewRef.current.scrollTo({y: scrollOffset, animated: false});
}, [getScrollOffset, route]);
<ScrollView
onScroll={onScroll}
ref={scrollViewRef}
>
We need to move the below title: https://github.com/Expensify/App/blob/0c618acc8b5a0b77eb27dfa049a18e3135c51c52/src/pages/Search/SearchTypeMenu.tsx#L167 to outside the scroll view.
To do it, remove: https://github.com/Expensify/App/blob/0c618acc8b5a0b77eb27dfa049a18e3135c51c52/src/pages/Search/SearchTypeMenu.tsx#L167
and add it to:
The detail style can be add later.
@lakchote will address this as a follow up to his PR
@dominictb are you available to work on a fix?
@luacmartins Yes. I can work on it
@dominictb how's the PR coming along?
@luacmartins I drafted the PR. I am testing a few test cases.
@dominictb how is it looking? Do you think you'd be able to raise a PR soon? Thank you!
@lakchote PR is ready for review.
Thank you, I've assigned a C+ available for review.
Fix has been deployed to staging.
https://github.com/user-attachments/assets/b360b81f-bbfd-45b4-8607-32aa430deb01
Demoting from blocker.
Reviewing
label has been removed, please complete the "BugZero Checklist".
The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.35-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-09-23. :confetti_ball:
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[Upwork Job]()
@anmurali, @lakchote, @luacmartins, @dominictb Whoops! This issue is 2 days overdue. Let's get this updated quick!
@anmurali Ready for payment.
Not overdue. Waiting for payment.
@anmurali, @lakchote, @luacmartins, @dominictb 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
Bump for payment @anmurali
@anmurali, @lakchote, @luacmartins, @dominictb 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
@anmurali, @lakchote, @luacmartins, @dominictb 10 days overdue. Is anyone even seeing these? Hello?
@dominictb - I need your Upwork profile @luacmartins - Do we need to pay $250?
@luacmartins @dominictb bump on ^^
Yes, that's $250 for @dominictb and @rushatgabhane for writing the PR and reviewing, respectively
@anmurali, @lakchote, @luacmartins, @rushatgabhane, @dominictb Huh... This is 4 days overdue. Who can take care of this?
Waiting on @dominictb
@anmurali, @lakchote, @luacmartins, @rushatgabhane, @dominictb Huh... This is 4 days overdue. Who can take care of this?
Waiting on payment
@anmurali, @lakchote, @luacmartins, @rushatgabhane, @dominictb Still overdue 6 days?! Let's take care of this!
@dominictb could you please give us your Upwork profile in order to pay you?
@anmurali, @lakchote, @luacmartins, @rushatgabhane, @dominictb 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
bump @dominictb for your Upwork profile.
@lakchote Sorry I missed this, mine is https://www.upwork.com/freelancers/~01f70bed1934fd35d5
@anmurali, @lakchote, @luacmartins, @rushatgabhane, @dominictb 12 days overdue. Walking. Toward. The. Light...
Accepted, thank you @anmurali
Not overdue. Should we close this?
Seems like we're all set. Gonna close the issue, please reopen if needed.
@anmurali @lakchote @luacmartins Be sure to fill out the Contact List!
@luacmartins @lakchote My contract was not paid by @anmurali yet, please help to reopen
Sorry, I thought that had been handled based on this comment. My bad 😅
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.35-0 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Expected Result:
In Step 4, the Saved title should remain on top when the list is scrolled down. In Step 6, the list will not scroll up after selecting the search at the bottom of the list, or the selected search will move to the top.
Actual Result:
In Step 4, the Saved title is also scrolled and hidden. In Step 6, the list scrolls up and the selected search is hidden.
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/b735f25e-a562-4cba-b558-682b0b7c26cf
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @anmurali