search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[Testing] Hold - Approve confirmation modal show full amount as full and partial option #49220

Open IuliiaHerets opened 4 days ago

IuliiaHerets commented 4 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.35-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): gocemate+workspaceapprover182@gmail.com Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  1. Login as the owner of the workspace
  2. Create a workspace
  3. Invite the approver and employee
  4. Navigate to more features
  5. Enable "workflows"
  6. On the "Workflow" editor - enable "Add Approvals"
  7. Set the Approver account as the Approver

Steps:

  1. As Employee submit 2 distance expenses to the workspace chat
  2. As Employee edit the first distance request by changing start or stop destination
  3. As Employee hold the first distance request
  4. As Approver click on green Approve button
  5. Verify confirmation modal appears

Expected Result:

Confirmation modal should show full and partial amount that should be approved

Actual Result:

Confirmation modal shows same amount (full amount as full and partial option)

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6602135_1726220780242!Capture

https://github.com/user-attachments/assets/6b4014cc-aba9-486a-820d-3ce98bb46df7

View all open jobs on GitHub

melvin-bot[bot] commented 4 days ago

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 4 days ago

We think that this bug might be related to #wave-collect - Release 1

IuliiaHerets commented 4 days ago

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

melvin-bot[bot] commented 23 hours ago

@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

strepanier03 commented 17 hours ago

Will prioritize this tomorrow.

strepanier03 commented 5 minutes ago

I've tested this twice now and I'm unable to reproduce this.

MelvinBot commented 4 minutes ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989