[HOLD for payment 2024-09-27] [$250] Onboarding modal is flashing briefly on transitioning to NewDot via ShortLivedAuthToken

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.35-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): (examples in the linked slack thread in #wave-collect. Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @anmurali Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1726074674036609

Action Performed:

_Note: we're still trying to nail down the prerequisites when it comes to the onboardingNVP state, but our best guess is that it needs to be empty._

1. Go to OldDot
2. Click Support
3. Click Concierge to be redirected to NewDot
4. Observe the brief flash of the onboarding modal

Expected Result:

No onboarding modal is shown, user lands in the Concierge DM chat

Actual Result:

Onboarding route briefly flashes in the URL bar causing the onboarding modal to appear and disappear

Workaround:

N/A, the modal does disappear again.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Customer vids from FullStory, so not uploading them here. Refer to these two slack chats in threads for the visual examples:

https://expensify.slack.com/archives/C036QM0SLJK/p1726079102789129?thread_ts=1726074674.036609&cid=C036QM0SLJK https://expensify.slack.com/archives/C036QM0SLJK/p1726079241599169?thread_ts=1726074674.036609&cid=C036QM0SLJK

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021835709139570374195
• Upwork Job ID: 1835709139570374195
• Last Price Increase: 2024-09-16

[melvin-bot[bot]]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[trjExpensify]

Apols for the noise, @twisterdotcom. GH wouldn't let me assign myself on creation. Swapped you out. 👍

[blazejkustra]

Hey! I’m Błażej Kustra from Software Mansion, and I’d like to work on this issue 😄

[mountiny]

PR merged

[trjExpensify]

Dope, thanks!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021835709139570374195

[melvin-bot[bot]]

Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

[trjExpensify]

PR is on staging. We can close it out when it hits prod, as no payments will be due here.

[mountiny]

@trjExpensify I believe we have to pay @allgandalf $250 for review and testing

[trjExpensify]

Ah yes, sorry. I missed that assignment. 👍

[allgandalf]

PR deployed to production yesterday

[CyberAndrii]

Can we revert it 🤔? https://github.com/Expensify/App/pull/49263#issuecomment-2359236679

[mountiny]

@allgandalf $250 for their review i believe

[allgandalf]

Chill melvin, only payment remains

[trjExpensify]

Payment summary as follows:

• $250 to @allgandalf for the review

Offer sent

[trjExpensify]

Paid, closing!