[$250] Room - Continue button becomes unresponsive when try to login via deep link

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.34-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4962361&group_by=cases:section_id&group_id=229066&group_order=asc Email or phone of affected tester (no customers): gocemate+a2133@gmail.com Issue reported by: Applause Internal Team

Action Performed:

1. Logout of New Expensify if logged in
2. Navigate to the following link - https://staging.new.expensify.com/r/6776919265133947
3. Click on Join button
4. Add email address
5. Click Continue

Expected Result:

Continue button should response

Actual Result:

Continue button becomes unresponsive

Workaround:

Unknown

Platforms:

• [x] Android: Native
• [x] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/06e418bd-b39e-423f-a7af-9411415c0e7a

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021837011332462278943
• Upwork Job ID: 1837011332462278943
• Last Price Increase: 2024-09-27

Issue Owner

Current Issue Owner: @eVoloshchak

[melvin-bot[bot]]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Continue button becomes unresponsive

What is the root cause of that problem?

When pressing on "Continue" button in sign in modal, it calls:

https://github.com/Expensify/App/blob/1e8d80e850af52e60ec0fefbe11553cc196e8fee/src/libs/actions/Session/index.ts#L420

The read API is only called if the networkRequestQueue's length in onyx is 0.

In case of this bug, before we click on "Continue", the networkRequestQueue's length in onyx greater than 0, so the Continue button seems to become unresponsive.

What changes do you think we should make in order to solve the problem?

Add isDisabled={networkRequestQueue.length > 0} to FormAlertWithSubmitButton will disable the Continue button when the networkRequestQueue's length is greater than 0.

We can also display additional messages such as "Some existing requests are running; cannot sign in now."

What alternative solutions did you explore? (Optional)

In this, we can call PersistedRequests.clear().

[melvin-bot[bot]]

@stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021837011332462278943

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[TheGithubDev]

Please re-state the problem that we are trying to solve in this issue:

The continue button becomes unresponsive when trying to login via deep link.

What is the root cause of that problem?

The root cause of this problem is in the baseloginform component.

What changes do you think we should make in order to solve the problem?

To address this issue the button click listener, validation logic and loading state should be checked.

What alternative solutions did you explore? ( OPTIONAL )

NA

[melvin-bot[bot]]

@eVoloshchak, @stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!

[stephanieelliott]

Hey @eVoloshchak there are some proposals here, can you review when you get.a sec?

[melvin-bot[bot]]

@eVoloshchak, @stephanieelliott Eep! 4 days overdue now. Issues have feelings too...

[stephanieelliott]

Hey @eVoloshchak there are some proposals here, can you review when you get.a sec?

Bump on this @eVoloshchak

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@eVoloshchak, @stephanieelliott Still overdue 6 days?! Let's take care of this!

[stephanieelliott]

Hey @eVoloshchak can you review please?

[melvin-bot[bot]]

@eVoloshchak @stephanieelliott this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!