[$250] Long State/Province text can not be saved on Address modal - Update the FE to match the 32 limit for the state field here for foreign addresses

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.35-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4963582&group_by=cases:section_id&group_order=asc&group_id=229064 Email or phone of affected tester (no customers): gocemate+a2148@gmail.com Issue reported by: Applause Internal Team

Action Performed:

1. Navigate to Settings -> Profile -> Personal details
2. Click on Address> Fulfil requested fields with non-USA details> Save
3. Click on Address> Add extra text in State/Province field> Save

Expected Result:

Edited State/Province info should update since user is allowed to add 50 characters

Actual Result:

Long State/Province can not be saved on Address modal

Workaround:

Unknown

Platforms:

• [x] Android: Native
• [x] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/1ba8ed5a-388a-41cf-9273-25f949f90a9a

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021836427775692517927
• Upwork Job ID: 1836427775692517927
• Last Price Increase: 2024-09-18

Issue Owner

Current Issue Owner: @rayane-djouah

[melvin-bot[bot]]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Long State/Province text can not be saved on Address modal

What is the root cause of that problem?

State/Province char limit for international address in BE is 32

What changes do you think we should make in order to solve the problem?

Create new const to store STATE_CHARACTER_LIMIT

STATE_CHARACTER_LIMIT: 32,

Update the max length for state/province https://github.com/Expensify/App/blob/8c5141ad3bfeaeb3dab47321e46d430028abdc3b/src/components/AddressForm.tsx#L209 https://github.com/Expensify/App/blob/8c5141ad3bfeaeb3dab47321e46d430028abdc3b/src/pages/MissingPersonalDetails/substeps/Address.tsx#L136

maxLength={CONST.STATE_CHARACTER_LIMIT}

Additionally we can adjust the STATE_CHARACTER_LIMIT value if needed

What alternative solutions did you explore? (Optional)

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021836427775692517927

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[trjExpensify]

Internal references:

• The 32 character limit for foreign addresses comes from here I think.
• From the PR that introduced it here, it sounds like it’s a limit enforced by Marqeta for foreign states:
  • "Marqeta now allows state for foreign addresses to be 32 characters long so we should update our form to match that so international users can easily order their E-cards"

So let's update the FE to match the BE's 32 character limit for states with foreign addresses. 👍

[rayane-djouah]

[rayane-djouah]

@nyomanjyotisa's proposal looks good to me,

:ribbon::eyes::ribbon: C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.