[$250] Search - App freezes after cache and cookie clean of chat filter

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.35-7 Reproducible in staging?: Y Reproducible in production?: N Found when validating PR : https://github.com/Expensify/App/pull/49258 Email or phone of affected tester (no customers): applausetester+bp0916w@applause.expensifail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

Precondition; logged in application.

1. Go to Search page > Chats
2. Click on Filters > Select some users for From field and save the search
3. Go to Troubleshoot > Reset cache and restart

Expected Result:

App doesn't crash. App doesn'r freeze

Actual Result:

App is freezed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/a3ed06fc-0200-4ae0-b91c-7a0f470f6a15

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021835730592300773674
• Upwork Job ID: 1835730592300773674
• Last Price Increase: 2024-09-23
• Automatic offers:
• rayane-djouah | Reviewer | 104197919

[melvin-bot[bot]]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #wave-control

[melvin-bot[bot]]

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Christinadobrzyn]

Asking everyone in this PR to take a peek - https://github.com/Expensify/App/pull/49258

[DylanDylann]

I can't reproduce this issue on the latest main

https://github.com/user-attachments/assets/9fbfb253-adaf-48b1-b206-37ede9848ad8

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021835730592300773674

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[mountiny]

I cannot reproduce in staging, it is testing feature

[mountiny]

https://github.com/user-attachments/assets/33909d59-b023-4af8-ba71-2c8d8a220b46

[mvtglobally]

Multiple testers were able to reproduce this one. Let me check now again. https://github.com/user-attachments/assets/0cf790f7-c925-4d9e-96d6-0cb3e74793d3

[grgia]

I can reproduce it on staging https://expensify.slack.com/archives/C01GTK53T8Q/p1726505749566979 but I agree let's not block deploy on this

[grgia]

https://expensify.slack.com/archives/C01GTK53T8Q/p1726505749566979

[mountiny]

cc @luacmartins @lakchote

[lakchote]

cc @luacmartins @lakchote

Tried again and couldn't reproduce, @luacmartins could you test it on your side?

[luacmartins]

Yea, I could reproduce on staging. I agree that this is low priority given it requires the troubleshoot menu, but still something we should look into

https://github.com/user-attachments/assets/729d1369-60ee-43ee-b744-ecab16811458

[Christinadobrzyn]

thanks for reviewing @luacmartins - is this a regression of https://github.com/Expensify/App/pull/49258 or a different issue?

[luacmartins]

Apparently this has been an issue for a while, so I don't think that's a regression form the linked issue

[Christinadobrzyn]

Awesome! Thanks for confirming @luacmartins. I'll see if SWM might be able to investigate this - https://expensify.slack.com/archives/C04878MDF34/p1726679430131789

[Kicu]

hey, I will spend some time checking this and see how much work this might be. I will post any updates later.

[luacmartins]

@Kicu I would prioritize the other Search v2.4 issues over this one, since this issue is quite low value given that the troubleshoot menu is only available on dev/staging and not to customers.

[Kicu]

OK I spent a few minutes on it, I find it impossible to reproduce on my dev environment - the "clear cache and restart" for me never finishes so I cannot see what in Search makes this flow break. Is it only clear cache after search that makes the app freeze?

[luacmartins]

I saw a comment on Slack about it happening before as well, so not entirely sure. Anyways, I think we can focus on other issues for now.

[rayane-djouah]

Not overdue, Melv. This is pending proposals from external contributors.

[Christinadobrzyn]

@Guccio163 from SWM can take this - they are just finishing up a current task

[rayane-djouah]

Nice!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[Christinadobrzyn]

This is going to be worked on by @Guccio163 when they are available.

[Christinadobrzyn]

heads up, I'm going to be ooo for the rest of the week. I don't think there's any reason to assign a new BZ teammate as we are waiting on @Guccio163 to work on this when they are ready.

[melvin-bot[bot]]

@tylerkaraszewski, @Christinadobrzyn, @rayane-djouah Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rayane-djouah]

Not overdue, https://github.com/Expensify/App/issues/49282#issuecomment-2371726467

[Christinadobrzyn]

checking in with @Guccio163 on taking this - https://expensify.slack.com/archives/C04878MDF34/p1727656958314559?thread_ts=1726679430.131789&cid=C04878MDF34

[Guccio163]

Hi, I'm Wiktor Gut from SWM, please assign me this issue

[melvin-bot[bot]]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

@tylerkaraszewski @Christinadobrzyn @rayane-djouah @Guccio163 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[Christinadobrzyn]

We're okay Melvin - this job is being worked on accordingly!

[Guccio163]

Hi @Christinadobrzyn, I'm just coming with an update on this issue; Right now I'm unable to reproduce this bug both on local and staging. After cleaning the cache one of two possible scenarios happen:

1. App refreshes gracefully:

https://github.com/user-attachments/assets/44afebe4-ba61-49e5-9a8a-93ac20a53417

2. Profile does not load, Inbox half-fully gives up on loading and search loads normally. I needed to refresh page and/or login once again to make it load:

https://github.com/user-attachments/assets/c61c2262-9891-4746-ae69-22788a839c47

I asked some guys from SWM to check if they can reproduce it to find a cause why I can't, I'll come back to you if I figure it out 🔜

P.S. the "Use staging server" turns off on cache clean-up only in local environment, recordings are from local because stage behaves exactly the same

[Christinadobrzyn]

Ah thank you for the update @Guccio163! Please let us know if there's anything we can do to help!

[rayane-djouah]

I'm not able to reproduce the bug. @izarutskaya Could you please retest this?

[Christinadobrzyn]

Asked QA to retest - https://expensify.slack.com/archives/C9YU7BX5M/p1728370749611919

[Guccio163]

Hi, I reached out to couple of colleagues from SWM to try and reproduce the bug, but no-one could. Nevertheless I see a big issue with Clear cache and restart button - It works non-deterministically sometimes right and sometimes so wrong it requires multiple cookie clean and manual refresh. I'm waiting for @izarutskaya's results though, we should decide what to do with this issue then 🔜

[kavimuru]

Able to reproduce freeze. Also user need user need to clean cache multiple times https://github.com/Expensify/App/issues/49282#issuecomment-2399147284 is true.

https://github.com/user-attachments/assets/5dd3685b-bb6b-48c0-939e-a44969c4dd30

[Christinadobrzyn]

Thanks @kavimuru - @Guccio163 will you please let us know if you need anything else to continue investigating/testing?

[Guccio163]

Hi @Christinadobrzyn, is there a specified number of refreshes needed for it to break? So far I got up to ~20 and I still cannot reproduce this one.

Also: @kavimuru have you tested if selecting a From filter is necessary in this case? It seems like the main case is refreshing since you have to fire it couple of times to work? Than we could shorten the reproductions steps simply to refreshing cache.

https://github.com/user-attachments/assets/93cc7ee7-ab88-4935-850e-7c99d056a310

[Christinadobrzyn]

Asking @kavimuru to review the questions - https://expensify.slack.com/archives/C9YU7BX5M/p1728624548081019?thread_ts=1728370749.611919&cid=C9YU7BX5M

[kavimuru]

@Guccio163 @Christinadobrzyn App freezes for me right after " Reset cache and restart" @

https://github.com/user-attachments/assets/cc555def-4714-46a5-a225-43a63afc0c94

[melvin-bot[bot]]

@tylerkaraszewski @Christinadobrzyn @rayane-djouah @Guccio163 this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[tylerkaraszewski]

People are working on it melvin.

[Christinadobrzyn]

@Guccio163 Feel free to let us know how we can help with testing this https://github.com/Expensify/App/issues/49282#issuecomment-2407603065 - TY!

[Guccio163]

Hi @kavimuru, could you please attach some technical specification of the device you're reproducing on? I've noticed that's MacBook/iMac, but I'm working on one too, so maybe it's the specification differences.