search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.43k stars 2.8k forks source link

[Payment Due 2024-10-07] There are reports with GBR indicators that appear when search for them, but they do not show up in the LHN for approval. #49318

Open m-natarajan opened 2 weeks ago

m-natarajan commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @coleaeason Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726515980761009

Action Performed:

  1. Create a Collect workspace
  2. Invite a submitter and two approvers
  3. Enable Workflows + Approvals
  4. Set Approver A as the workspace approver
  5. As the submitter, submit an expense in your workspace chat
  6. As the admin, change the approver from Approver A to Approver B

Expected Result:

Approver A should be removed from the workspace chat, but they should retain the report from the submitter in LHN with GBR.

Actual Result for @coleaeason:

Approver A doesn't have the report in LHN. The report shows when searched for and shows as GBR when it's in his LHN after searching.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

MelvinBot commented 2 weeks ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

garrettmknight commented 2 weeks ago

Asked in thread for more details around the reports.

Beamanator commented 2 weeks ago

Commenting to keep an eye on this. This should have been fixed w/ these PRs:

Basically as of these PRs, the expense reports should be showing in the LHN AS LONG AS all of these are true:

  1. isExpenseReport(report)
  2. report?.hasParentAccess === false
  3. report?.managerID === currentUserAccountID
    • We might want to remove this :D
garrettmknight commented 2 weeks ago

Assigning @Beamanator based on his theory above.

Beamanator commented 2 weeks ago

Will get to this today 🙏

Beamanator commented 2 weeks ago

PR is up! ^

jjcoffee commented 1 week ago

@JmillsExpensify Could I get assigned here for payment as the PR reviewer? Thanks!

jjcoffee commented 3 days ago

Deployed to production yesterday, so should be due for payment 2024-10-07.