Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[$250] Set `syncCustomLists` and `syncCustomSegments` to true in the NetSuite config when a user has one or more set in their configuration #49363

Closed yuwenmemon closed 1 day ago

yuwenmemon commented 1 day ago

Problem

One thing we forgot about in the NetSuite project when building the integration configuration in New Expensify is that we need to set two boolean style configs whenever we have a Custom Segment or Custom List that we're importing.

Screenshot 2024-09-17 at 10 41 15 PM

This create issues when importing and exporting those segments and/or lists

Solution

  1. If we ever update the NetSuite configuration for a workspace to add a Custom Segment such that there is > 1 entry insyncOptions.customSegmentsthen we should setsyncOptions.syncCustomSegmentstotrue`
  2. If we ever update the NetSuite configuration for a workspace to add a Custom List such that there is > 1 entry in syncOptions.customLists then we should set syncOptions.syncCustomLists to true
  3. If the customSegments or customLists array is ever empty when saving a configuration (i.e. we remove the last Custom Segment or list) we should set syncCustomLists / syncCustomSegments to false

Screenshot 2024-09-17 at 10 46 28 PM

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021836280909533854916
  • Upwork Job ID: 1836280909533854916
  • Last Price Increase: 2024-09-18
Issue OwnerCurrent Issue Owner: @rushatgabhane
melvin-bot[bot] commented 1 day ago

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

yuwenmemon commented 1 day ago

@mananjadhav @shubham1206agra Putting this under your radar in case you wanted to knock it out real quick

melvin-bot[bot] commented 1 day ago

Job added to Upwork: https://www.upwork.com/jobs/~021836280909533854916

melvin-bot[bot] commented 1 day ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

shubham1206agra commented 1 day ago

@yuwenmemon Can you tell me the use of this? Cause we don't use it anywhere.

yuwenmemon commented 1 day ago

It's used in the back-end to control what data gets imported and exported. But hmmmm... now that you mention it, we don't use it anywhere in the client itself... So I'll actually handle this internally in the API - thanks for the gut check! 🙇🏽