Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[HOLD for payment 2024-10-10] Improve the metrics doccumentation #49376

Closed mountiny closed 1 month ago

mountiny commented 2 months ago

Coming from this thread

Problem

Various performance metrics are currently sent to Firebase for monitoring and analysis. However, team members struggle to understand, interpret, and utilize the performance data effectively. This difficulty can result in misunderstandings, misinterpretations, and challenges in leveraging metrics to drive performance improvements.

Some examples where it’s not clear what metrics are representing and what is the difference between them:

Solution

To resolve this issue, let’s create comprehensive documentation for our performance metrics. The documentation should include:

  1. Metric Definitions and Descriptions: Provide clear definitions and detailed descriptions of each performance metric.
  2. Data Collection Process: Explain how each metric is collected, including the start and end points of the data collection process.
  3. Documentation Maintenance: Outline the steps for updating and maintaining the documentation as new metrics are added or existing metrics are modified.

This documentation will be included in the project’s README to ensure easy access and reference for everyone.

melvin-bot[bot] commented 2 months ago

Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

TMisiukiewicz commented 2 months ago

Hi, I'm Tomasz from Callstack, I'd like to work on this issue

mountiny commented 1 month ago

not overdue

TMisiukiewicz commented 1 month ago

I have documented all the metrics we send to Firebase. Should we also include descriptions for the metrics collected exclusively by the Performance module (used by react-native-performance, not being sent anywhere)?

mountiny commented 1 month ago

I think it does not hurt if you document that as well.

TMisiukiewicz commented 1 month ago

PR is open ✅

melvin-bot[bot] commented 1 month ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.43-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-10. :confetti_ball:

For reference, here are some details about the assignees on this issue: