[HOLD for production 2024-10-07][$250] [Search v2.3] Add the bookmark icon for Saved searches on mobile

[lakchote]

See https://github.com/Expensify/App/pull/48566#issuecomment-2350223656

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021836682788967357264
• Upwork Job ID: 1836682788967357264
• Last Price Increase: 2024-09-19

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021836682788967357264

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add the bookmark icon for Saved searches on mobile

What is the root cause of that problem?

On mobile, we display the saved search query that we're viewing here

https://github.com/Expensify/App/blob/37bf6b2fef128786dfcd83257a56f56c0cd1eb3d/src/pages/Search/SearchTypeMenuNarrow.tsx#L87

And we don't add icon field for the saved searches item https://github.com/Expensify/App/blob/37bf6b2fef128786dfcd83257a56f56c0cd1eb3d/src/pages/Search/SearchTypeMenuNarrow.tsx#L108

What changes do you think we should make in order to solve the problem?

We should remove this item here because it will be included in the savedSearchItems below or we can exclude the viewing saved search in savedSearchItems

https://github.com/Expensify/App/blob/37bf6b2fef128786dfcd83257a56f56c0cd1eb3d/src/pages/Search/SearchTypeMenuNarrow.tsx#L87

Add icon field as Expensicons.BookMark here, we can also add other icon config field if it needs

icon: Expensicons.Bookmark,

https://github.com/Expensify/App/blob/37bf6b2fef128786dfcd83257a56f56c0cd1eb3d/src/pages/Search/SearchTypeMenuNarrow.tsx#L108

What alternative solutions did you explore? (Optional)

[thesahindia]

We should remove this item here because it will be included in the savedSearchItems below or we can exclude the viewing saved search in savedSearchItems

The solution for adding icon is fine but I am not sure I understand what you said above. Could you explain it?

[mkzie2]

If we're viewing a saved search, we shouldn't add the custom query option to the bottom modal. Example: In the imagine below, the type:expense status:all currency:ALL AMD shouldn't be shown

As the ref comment here mentioned, we shouldn't display the viewing saved search query in popoverMenuItems or savedSearchItems

[thesahindia]

Got it!

[thesahindia]

@mkzie2's proposal looks fine to me!

🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Current assignee @lakchote is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[lakchote]

@mkzie2's proposal LGTM.

[melvin-bot[bot]]

📣 @mkzie2 You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖

[mkzie2]

Will raise the PR soon.

[mkzie2]

@thesahindia The PR is ready https://github.com/Expensify/App/pull/49583.

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @lakchote, @luacmartins, @thesahindia, @mkzie2 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mkzie2]

@lakchote Can we process payment here?

[melvin-bot[bot]]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lakchote]

@VictoriaExpensify please process payment for @mkzie2, thanks!

[melvin-bot[bot]]

@lakchote, @luacmartins, @VictoriaExpensify, @thesahindia, @mkzie2 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

Waiting on payment

[VictoriaExpensify]

Hey @mkzie2 - can you please accept the job offer and I'll organise payment https://www.upwork.com/nx/wm/offer/104530588

[mkzie2]

@VictoriaExpensify Did it thank you

[thesahindia]

Hey @VictoriaExpensify, I am eligible for the C+ compensation. I will request it on new dot. Could you please add the payment summary here? I will need it to get the money request approved.

[VictoriaExpensify]

Payment summary: Contributor: @mkzie2 - Paid $250 via Upwork Contributor+: @thesahindia - owed $250 via NewDot