Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

Members invited to a workspace on NewDot that doesn’t have isPolicyExpenseChatEnabled set to `true` appear “Hidden” in the Members table. #49465

Closed m-natarajan closed 1 month ago

m-natarajan commented 2 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.38-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: Internal logSearch requestID. Expensify/Expensify Issue URL: Issue reported by: @trjExpensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726740074985259

Action Performed:

  1. Go to Classic
  2. Sign-up for a new account using a private email address
  3. Create a Control workspace
  4. Switch to NewDot
  5. Go to Account > Workspaces > Members
  6. Invite a couple of new accounts
  7. Observe how they appear “Hidden” in the members table
  8. Click on one of the “Hidden” rows

Expected Result:

Members should be visible in the members table and their profile accessible in the RHP.

Actual Result:

NotFound error in the RHP and the URL path /members/0

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/be460482-6b7e-47f0-9584-b25b26b2ed6e

https://github.com/user-attachments/assets/10a24741-31af-4289-b879-732b7f946891

Add any screenshot/video evidence

View all open jobs on GitHub

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

trjExpensify commented 2 months ago

Added my requestID to the OP.

@mountiny had an idea of what might be up here:

Idea: the personal details data is missing as normally it would be pushed along with the new workspace chat data, which is missing in the case of when the beta is not enabled. And possibly we do not push the personal details on their own to the policy members

CC: @puneetlath as you have some knowledge on hidden and personalDetails shizzz.

trjExpensify commented 1 month ago

@dylanexpensify one to call out in Hot picks in the update. :)

melvin-bot[bot] commented 1 month ago

@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

trjExpensify commented 1 month ago

@dylanexpensify any takers?

melvin-bot[bot] commented 1 month ago

@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

trjExpensify commented 1 month ago

@dylanexpensify is this getting called out?

melvin-bot[bot] commented 1 month ago

@trjExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

trjExpensify commented 1 month ago

Bumped in thread: https://expensify.slack.com/archives/C06ML6X0W9L/p1728064226162109?thread_ts=1727729324.688989&cid=C06ML6X0W9L

rlinoz commented 1 month ago

I will take a look at this one

trjExpensify commented 1 month ago

Love it, thanks!

rlinoz commented 1 month ago

Here it is what we will need to do:

  1. Update Auth to consider invited accounts as definitely known by the inviter
  2. Remove the onyx updates for personalDetailsList from PHP, since that is overriding the values from Auth

Working on both of the changes.

rlinoz commented 1 month ago

I don't know where I was with my head in the comment above since it has nothing to do with reports but with Policy sharing, anyway, PR is up https://github.com/Expensify/Auth/pull/12701

trjExpensify commented 1 month ago

Wahoo, that's merged.

rlinoz commented 1 month ago

Fix is in prod, tested and it works!

Screenshot 2024-10-10 at 11 23 32