search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.53k stars 2.88k forks source link

Expense - Banner shows user email/name first, then "You" instead of "You" directly #49484

Closed IuliiaHerets closed 1 month ago

IuliiaHerets commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.38-1 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Issue was found when executing this PR: https://github.com/Expensify/App/pull/49315 Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit an expense.
  4. Go to expense report.

Expected Result:

The banner will directly display "You" in "Waiting for You's expense(s) to..."

Actual Result:

The banner shows user email (or name if there is custom name) first, then "You" in "Waiting for You's expense(s) to..."

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/6276b6e3-ea54-48fa-a5eb-e6c1e73191cd

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 1 month ago

We think that this bug might be related to #wave-collect - Release 1

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 1 month ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
IuliiaHerets commented 1 month ago

Sorry, didn't add a blocker label, fixed

ishpaul777 commented 1 month ago

fix is under review https://github.com/Expensify/App/pull/49482

srikarparsi commented 1 month ago

Awesome thanks! Will check back once this gets gets CPed

grgia commented 1 month ago

Just triggered CP for https://github.com/Expensify/App/pull/49482 Progress on build here

srikarparsi commented 1 month ago

This has been fixed with this PR:

image

Going to close this out. Also @grgia do you know if there's plans to make the "Your" lowercase?