[$250] Web - Control Workspace - The approver in next steps does not change to the owner

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.38-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4984506 Email or phone of affected tester (no customers): dave0123seife@gmail.com Issue reported by: Applause Internal Team

Action Performed:

Preconditions:

Control workspace has advanced approval set with 2 approvers

Employee submits to approver A Approver A submits to approver B Approver B is the final approver

Employee

• Navigate to the workspace chat and submit a expense

Admin steps - OldDot

1. Navigate to the workspace settings > Members
2. Remove Approver A and B from the approval flow so they're not approvers anymore
3. Set the approvals to the admin (owner of the workspace)

Admin steps - NewDot

1. Log in as the admin (owner)
2. Navigate to the employee workspace chat
3. Click on the header > members

Expected Result:

The previous approver have been removed from the chat member list and the approver in next steps is the owner of the workspace

Actual Result:

The previous approver have not been removed from the chat member list and the approver in next steps is not the owner of the workspace

Workaround:

Unknown

Platforms:

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/7aaff1e4-d249-4613-acf7-772ee7ca6e76

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021842133983186199999
• Upwork Job ID: 1842133983186199999
• Last Price Increase: 2024-10-18

Issue Owner

Current Issue Owner: @suneox

[melvin-bot[bot]]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot[bot]]

@dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[dylanexpensify]

@Beamanator as I think this is related to our wave-control initiative cc @garrettmknight

[Beamanator]

Hmm ok so there's 2 things reported here and here are my thoughts:

The previous approver have not been removed from the chat member list

The previous approvers (A & B) definitely should have been removed from the workspace chat IFF they're non-admins

and the approver in next steps is not the owner of the workspace

I believe the new approver (workspace owner) should NOT be in the next steps as the approver because the first step taken was Employee submits to approver A which makes approver A the report manager & that report manager shouldn't change when the approval chain is updated

[melvin-bot[bot]]

@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot[bot]]

@dylanexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[dylanexpensify]

Thanks for clarifying @Beamanator! Should we then break this into two issues, one for each scenario?

[Beamanator]

aah maybe i wasn't too clear - i was thinking there's actually only 1 bug here, even though 2 different "bugs" were reported

[melvin-bot[bot]]

@dylanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021842133983186199999

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[dylanexpensify]

Pending proposals

[melvin-bot[bot]]

@suneox, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[suneox]

@MelvinBot not overdue, still pending proposals

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@suneox, @dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

[suneox]

Same above

[melvin-bot[bot]]

@suneox @dylanexpensify this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot[bot]]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dylanexpensify]

Hey @greg-schroeder! I'm heading out on parental leave so reassigning this! TY! 🙇‍♂️

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot[bot]]

@suneox, @greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[suneox]

Issue not reproducible so still waiting KI retest on next week

[greg-schroeder]

closing as not reproducible