Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

Search – Pinned chat in offline mode is not displayed in pinned chats on Search #49522

Closed IuliiaHerets closed 1 hour ago

IuliiaHerets commented 2 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.39-0 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Issue was found when executing this PR: https://github.com/Expensify/App/pull/49186 Email or phone of affected tester (no customers): gocemate+a2212@gmail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Open staging.new.expensify.com
  2. Go to Troubleshoot> Go offline
  3. Go to LHN> Right click> Pin a conversation
  4. Go to Search> Chats> Pinned

Expected Result:

Pinned chat in offline mode should be displayed in pinned chats results in Search

Actual Result:

Pinned chat in offline mode is not displayed in pinned chats results in Search

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/ab9e4374-a839-4a91-86f0-b4c0310a5242

View all open jobs on GitHub

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 hours ago

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 2 hours ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
IuliiaHerets commented 2 hours ago

We think that this bug might be related to #wave-control

grgia commented 2 hours ago

Feature added in https://github.com/Expensify/App/pull/49186

grgia commented 2 hours ago

@luacmartins

luacmartins commented 1 hour ago

This is expected. Search doesn't work offline. Closing.