search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

Login - "Get Started! Submit your first expense" message is displayed over Concierge Chat #49566

Open izarutskaya opened 6 hours ago

izarutskaya commented 6 hours ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.39-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): gibethlehem@gmail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

  1. Create a workspace
  2. Add a new user(not created account before) to the workspace.
  3. Login with the new user

Expected Result:

"Get Started! Submit your first expense" message is displayed over the workspace chat

Actual Result:

"Get Started! Submit your first expense" message is displayed over the Concierge Chat,

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/58723d62-fccb-4c16-bc6c-8071d1e2e44b

View all open jobs on GitHub

melvin-bot[bot] commented 6 hours ago

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

NJ-2020 commented 6 hours ago

Edited by proposal-police: This proposal was edited at 2024-09-21 08:56:41 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Get Started! Submit your first expense" message is displayed over Concierge Chat

What is the root cause of that problem?

Right here we do not exclude if it is a concierge chat https://github.com/Expensify/App/blob/9160fa585c26d3312fd6d6fbd69d334e66cb373d/src/pages/home/report/ReportFooter.tsx#L221 https://github.com/Expensify/App/blob/9160fa585c26d3312fd6d6fbd69d334e66cb373d/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx#L424-L426

What changes do you think we should make in order to solve the problem?

We can exclude if it is a concierge chat by using !ReportUtils.isConciergeChatReport(report) Or we can only show the tooltip if it is workspace chat by using ReportUtils.isWorkspaceChat(report.chatType)

What alternative solutions did you explore? (Optional)

We can show only the tooltip if we can request money inside the report by using canRequestMoney function

const participantAccountIDs = report.participantAccountIDs?.filter((accountID) => currentUserPersonalDetails?.accountID !== accountID);
ReportUtils.canRequestMoney(report, policy, participantAccountIDs)

Alternative 2

We can use getMoneyRequestOptions function to check if the return value include submit (request) then we can show the tooltip This is also same as we use canCreateRequest function