Closed IuliiaHerets closed 1 month ago
Triggered auto assignment to @JmillsExpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Triggered auto assignment to @nkuoch (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
We think that this bug might be related to #wave-control
I don't think this is a deploy blocker. All messages showing up is the expected behavior. Only thing that needs to be fixed is the unread marker jumping around.
I can take this issue as part of the Search project
Job added to Upwork: https://www.upwork.com/jobs/~021838084013513034465
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External
)
📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Keep in mind: Code of Conduct | Contributing 📖
Looking for proposals!
Hi team,
I'm a bit confused about this point:
Pinned chat should be present in the Pinned section Actual Result: All messages between users from the pinned chat are displayed in the Pinned section search.
As far as I know, we don't have the ability to pin individual messages in a chat; we can only pin the entire chat/report itself.
Do you mean that when a user pins a chat, only one entry (the pinned chat) should appear in the Pinned section? And when clicking on it, it should simply open the chat thread with all its messages?
@abzokhattab as I mentioned here, that part is expected. We should only fix the unread marker jumping around.
Looks like @wildan-m's proposal on another issue can fix the unread maker issue here.
@wildan-m Are you interested in looking into this issue?
@rayane-djouah sure. Thanks for mentioning that @QichenZhu
We are not updating unread marker time when the last unread report action deleted
We can update unread marker time when some of the report actions deleted, we can add new condition to indicate some report action deleted add this condition: mostRecentReportActionCreated >= prevMostRecentReportActionCreated
Change this code to:
const mostRecentReportActionCreated = sortedVisibleReportActions[0]?.created ?? '';
const prevMostRecentReportActionCreated = usePrevious(mostRecentReportActionCreated);
useEffect(() => {
if (unreadMarkerReportActionID) {
return;
}
if (mostRecentReportActionCreated <= unreadMarkerTime && mostRecentReportActionCreated >= prevMostRecentReportActionCreated) {
return;
}
setUnreadMarkerTime(mostRecentReportActionCreated);
To maintain the unread marker visible after repeated search clicks, lastReadTime
should not be updated in openReport
. A backend modification is needed to introduce a new parameter shouldUpdateLastReadTime
set to true for routes other than SCREENS.SEARCH.REPORT_RHP
.
Also wrap setUnreadMarkerTime
in src/pages/home/report/ReportActionsList.tsx
with the REPORT_RHP
check
const [unreadMarkerTime, setUnreadMarkerTime] = useState(report.lastReadTime ?? '');
const setUnreadMarkerTimeIfNotSearchReport = (lastReadTime: string) => {
if(route.name === SCREENS.SEARCH.REPORT_RHP)
{
return;
}
setUnreadMarkerTime(lastReadTime)
}
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@rayane-djouah let me know what you think of the updated proposal https://github.com/Expensify/App/issues/49570#issuecomment-2375568811
@luacmartins This bug is no longer reproducible because it was caused by PR #48445, which was reverted in PR #49770. I think we can close this issue.
@IuliiaHerets Could you please retest and confirm whether this issue is no longer reproducible?
https://github.com/user-attachments/assets/5e08d3f9-9f3d-4419-8f8b-5fc8bc5bd6af
Cool, I agree. Let's close this out once @IuliiaHerets confirms.
@luacmartins This bug report contains two issues.
https://github.com/user-attachments/assets/15f7d99f-e44b-48c0-bb27-d033ca10cbd8
Thanks for confirming!
All messages are displayed in Pinned section ( not sure if that's expected, it is still repro)
Yes, this is expected
Cool, seems like the issue here is resolved. Closing.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.39-0 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Issue was found when executing this PR: https://github.com/Expensify/App/pull/49186 Email or phone of affected tester (no customers): gocemate+a2244@gmail.com Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
Pinned chat should be present in Pinned section and when open a message green line should remain on the first unread message
Actual Result:
All messages between users from pinned chat are displayed in search pinned section. When open few messages green line change it's position
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/bb0a7573-0660-4eac-8eac-b974961ca548
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @s77rt