Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.54k stars 2.89k forks source link

Desktop - In-app 'Allow location access' Modal not appear #49571

Closed izarutskaya closed 1 month ago

izarutskaya commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.39-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/App/pull/39875 https://expensify.testrail.io/index.php?/runs/view/25017&group_by=cases:section_id&group_order=asc&group_id=306203 Email or phone of affected tester (no customers): rybkina+071624@gmail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

Precondition: Location permission DISABLED / Location feature OFF

  1. Create a money request from another user via the scan receipt flow
  2. Submit it
  3. In-app 'Allow location access' Modal should appear

Expected Result:

In-app 'Allow location access' Modal should appear.

Actual Result:

Desktop - In-app 'Allow location access' Modal not appear.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/93e73fa4-320a-4ace-b4cf-12d3f68ca614

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

stephanieelliott commented 1 month ago

We wouldn't need the location info in this scenario so I don't think it's a problem that the modal isn't appearing -- gonna close.