search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.35k stars 2.78k forks source link

[A/B Testing][Combined Track Submit] Define logic for displaying test to half of users #49591

Open grgia opened 4 days ago

grgia commented 4 days ago

Show combinedTrackSubmit to 1/2 of all users

So we would take this off beta, and write the logic such that when either global create or the create menu from a chat (or room) is clicked - all even numbered account IDs always see Create Expense and all odd numbered see Track and Submit per usual. We don’t need any of the NVPs as I can just use funnels in Full story.

https://expensify.slack.com/archives/C07HPDRELLD/p1726854156845179?thread_ts=1726506289.927939&cid=C07HPDRELLD

grgia commented 4 days ago

https://github.com/Expensify/App/blob/main/src/libs/Permissions.ts#L48-L52

Thinking we just remove the beta and then add the even/odd logic here instead- we could even create a new Permissions file for handling all the logic for future A/B tests.

anmurali commented 4 days ago

we could even create a new Permissions file for handling all the logic for future A/B tests.

Can you discuss your proposed solution in #engineering-chat tomorrow and make sure we're not missing anything? Then we can move forward with this. I just don't know enough to spot if there's any concerns with this route.

grgia commented 1 day ago

Done @anmurali https://expensify.slack.com/archives/C03TQ48KC/p1727344068209649