[$250] Hybrid app - "Welcome to Expensify" modal when signing into the existing account on a new device.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.39-0 Reproducible in staging?: Y Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @puneetlath Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726864963819969

Action Performed:

1. Go to staging.new.expensify.com and create an account (Any other platform)
2. Signin with the same credentials on Hybrid app
3. Tap Try New Expensify from menu

   Expected Result:

   No welcome modal as user already signed in another platform

   Actual Result:

   "Welcome to Expensify" modal when signing in

   Workaround:

   Unknown

   Platforms:

   Which of our officially supported platforms is this issue occurring on?

   • [ ] Android: Native
   • [ ] Android: mWeb Chrome
   • [x] iOS: Native
   • [ ] iOS: mWeb Safari
   • [ ] MacOS: Chrome / Safari
   • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021838490385865012073
• Upwork Job ID: 1838490385865012073
• Last Price Increase: 2024-10-08

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot[bot]]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bfitzexpensify]

Agree that the Welcome to Expensify modal shouldn't appear in this scenario. Adding the external label.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021838490385865012073

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[klajdipaja]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The user has already logged into the New Expensify on a web browser but when he logs into the hybrid app he is shown the welcome to new Expensify modal even though he has already been using it in the web.

What is the root cause of that problem?

We have not taken into account that the user might login first through the web and then in the app. The functions that check if the user should see the welcome modal use the onyx key nvp_tryNewDot.classicRedirect.completedHybridAppOnboarding which is only set when the user logs on the native app on the first time.

What changes do you think we should make in order to solve the problem?

We can use the nvp_onboarding.hasCompletedGuidedSetupFlow flag from onyx to detect that the user has already used the NewDot. This flag when an account is used in the web for the first time is set to to true but on the native app is set to true only once the guided welcome flow has completed. If we add this into the isFirstTimeHybridAppUser function in https://github.com/Expensify/App/blob/main/src/libs/actions/Welcome/index.ts we can make sure that the welcome message does not show. The first check in that function should be the following:

   const hasCompletedGuidedSetupFlow = !(Array.isArray(onboarding) || onboarding?.hasCompletedGuidedSetupFlow === undefined) && onboarding?.hasCompletedGuidedSetupFlow
        if (hasCompletedGuidedSetupFlow) {
            return;
        }

We can also put this block before isFirstTimeHybridAppUser is called:

function handleHybridAppOnboarding() {
    if (!NativeModules.HybridAppModule) {
        return;
    }
       const hasCompletedGuidedSetupFlow = !(Array.isArray(onboarding) || onboarding?.hasCompletedGuidedSetupFlow === undefined) && onboarding?.hasCompletedGuidedSetupFlow
        if (hasCompletedGuidedSetupFlow) {
            return;
        }

What alternative solutions did you explore? (Optional)

[melvin-bot[bot]]

@bfitzexpensify, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@bfitzexpensify, @alitoshmatov Still overdue 6 days?! Let's take care of this!

[bfitzexpensify]

Proposal ready for review in https://github.com/Expensify/App/issues/49611#issuecomment-2370707723 @alitoshmatov

[melvin-bot[bot]]

@bfitzexpensify, @alitoshmatov Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[alitoshmatov]

I couldn't reproduce it in our existing app. As far as I understand this is only happening in hybrid app(which I don't have much info about). But based on this C+ should get access soon.

@bfitzexpensify I am not sure what is the next step. If it is not an urgent issue I think we can hold till C+ get access and we can continue then

[melvin-bot[bot]]

@bfitzexpensify @alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[bfitzexpensify]

If it is not an urgent issue I think we can hold till C+ get access and we can continue then

Agreed. Setting to weekly and starring myself to keep checking in on this. We can revisit once C+ have access

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸