search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.5k stars 2.85k forks source link

Whisper to admin and auditor when their role is changed to user #49634

Open garrettmknight opened 1 month ago

garrettmknight commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: N/A Reproducible in staging?: N Reproducible in production?: N Expensify/Expensify Issue URL: Issue reported by: @JmillsExpensify Slack conversation: https://expensify.slack.com/archives/C06ML6X0W9L/p1727169064223989?thread_ts=1726494273.889699&cid=C06ML6X0W9L

Problem

When we change a user's role from Admin or Auditor to user we remove them from all workspace chats they had access to, except for their own. Since they've been removed from the #admins room for the workspace, they won't have any context on their role change or why they no longer have access to the chats they once did.

Solution

Similar to how we handle approvers who are removed from workspace chats (PR for that here), we'll send a whisper to admins and auditors in their workspace chat when their role is updated and access to other workspace chats is removed.

Admin copy for the whisper:

[Admin] updated your role in [Workspace Name] from admin to user. You have been removed from all submitter workspace chats except for your own.

Auditor copy for the whisper:

[Admin] updated your role in [Workspace Name] from auditor to user. You have been removed from all submitter workspace chats except for your own.

Platforms:

All

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

bfitzexpensify commented 3 weeks ago

Remains a hot pick, waiting to be picked up

bfitzexpensify commented 2 weeks ago

Remains a hot pick, waiting to be picked up

bfitzexpensify commented 4 days ago

Same update - remains a hot pick, waiting to be picked up. Weekly still seems right to me