[HOLD for payment 2024-10-29] [Wave Control] [QBD] Handle the syncing for QBD

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.51k stars 2.86k forks source link

[HOLD for payment 2024-10-29] [Wave Control] [QBD] Handle the syncing for QBD #49698

Open lakchote opened 1 month ago

lakchote commented 1 month ago

Will be worked on by an external contributor (see https://expensify.slack.com/archives/C03SLTAEULW/p1726876645021139).

Design doc link: https://docs.google.com/document/d/1LQNlTBlHjFqRdru_4UkqVr0QRseNNDq2IhFFpXcgfwY/edit#bookmark=id.1wvr9f4uk5jl

hoangzinh commented 3 weeks ago

Hi @lakchote can you double check if QBD has the same sync stage as QBO https://github.com/Expensify/App/blob/521e6dd8f477fa586b77e444945b08d3c031538c/src/CONST.ts#L2332-L2347

I'm going to copy translation text of sync stages but just wanna be confirmed.

lakchote commented 3 weeks ago

@hoangzinh here are the correct stages for QBD:

    QBD_IMPORT_TITLE("quickbooksDesktopImportTitle"),
    QBD_IMPORT_ACCOUNTS("quickbooksDesktopImportAccounts"),
    QBD_IMPORT_APPROVE_CERTIFICATE("quickbooksDesktopImportApproveCertificate"),
    QBD_IMPORT_DIMENSIONS("quickbooksDesktopImportDimensions"),
    QBD_IMPORT_CLASSES("quickbooksDesktopImportClasses"),
    QBD_IMPORT_CUSTOMERS("quickbooksDesktopImportCustomers"),
    QBD_IMPORT_VENDORS("quickbooksDesktopImportVendors"),
    QBD_IMPORT_EMPLOYEES("quickbooksDesktopImportEmployees"),
    QBD_IMPORT_MORE("quickbooksDesktopImportMore"),
    QBD_IMPORT_GENERIC("quickbooksDesktopImportSavePolicy"),

hoangzinh commented 3 weeks ago

Thanks @lakchote

hoangzinh commented 3 weeks ago

Hi @lakchote I'm working on this issue, sorry I couldn't spin up my PR because my init connection PR hasn't been merged yet, but can you check the API command SyncPolicyToQuickbooksDesktop works as expected? I tried to test it locally and Pusher hasn't sent any events to update the status.

https://github.com/user-attachments/assets/cee46a29-8b61-4588-8c0b-be4edbd7be51

lakchote commented 3 weeks ago

Hi @lakchote I'm working on this issue, sorry I couldn't spin up my PR because my init connection PR hasn't been merged yet, but can you check the API command SyncPolicyToQuickbooksDesktop works as expected? I tried to test it locally and Pusher hasn't sent any events to update the status.

Found the issue, thanks for noticing it. I'm raising a backend PR and will let you know once this is deployed.

lakchote commented 3 weeks ago

@hoangzinh the PR is deployed, you should be able to get pusher updates now.

hoangzinh commented 2 weeks ago

Thanks @lakchote

hoangzinh commented 2 weeks ago

@lakchote can you check if we also miss 'quickbooksDesktopWebConnectorReminder'

https://github.com/user-attachments/assets/3995d570-6b3d-4d69-843c-bc3077714e8e

lakchote commented 2 weeks ago

@lakchote can you check if we also miss 'quickbooksDesktopWebConnectorReminder'

here it is @hoangzinh:

quickbooksDesktopWebConnectorReminder: 'Still syncing data with QuickBooks... Please make sure the Web Connector is running',

melvin-bot[bot] commented 1 week ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.51-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/50500

If no regressions arise, payment will be issued on 2024-10-29. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@hoangzinh requires payment (Needs manual offer from BZ)

hoangzinh commented 3 days ago

@lakchote can you add @ZhenjaHorbach and BZ team to this issue so we can process payment later.

melvin-bot[bot] commented 2 days ago

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lakchote commented 2 days ago

@VictoriaExpensify please process payment for both @hoangzinh and @ZhenjaHorbach thanks!

melvin-bot[bot] commented 2 days ago

Payment Summary

[Upwork Job]()

Reviewer: @hoangzinh owed $250 via NewDot
ROLE: @ZhenjaHorbach paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@VictoriaExpensify)

[ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
[ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
[ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
[ ] I have verified the payment summary above is correct

VictoriaExpensify commented 5 hours ago

Hey @lakchote @hoangzinh - can I just confirm that $250 is the correct payment amount here?