[HOLD for payment 2024-10-25] [Wave Control] [QBD] Advanced settings main page

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.51k stars 2.86k forks source link

[HOLD for payment 2024-10-25] [Wave Control] [QBD] Advanced settings main page #49714

Closed lakchote closed 2 days ago

lakchote commented 1 month ago

Will be worked on by an external contributor (see https://expensify.slack.com/archives/C03SLTAEULW/p1726876645021139).

Design doc link: https://docs.google.com/document/d/1LQNlTBlHjFqRdru_4UkqVr0QRseNNDq2IhFFpXcgfwY/edit#bookmark=id.vnq8rnmobwkj

melvin-bot[bot] commented 1 week ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 week ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.50-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/50837

If no regressions arise, payment will be issued on 2024-10-25. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@ZhenjaHorbach requires payment (Needs manual offer from BZ)

melvin-bot[bot] commented 6 days ago

Issue is ready for payment but no BZ is assigned. @trjExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

melvin-bot[bot] commented 6 days ago

Payment Summary

[Upwork Job]()

ROLE: @ZhenjaHorbach paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@trjExpensify)

[ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
[ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
[ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
[ ] I have verified the payment summary above is correct

trjExpensify commented 6 days ago

👋 checklist time!

ZhenjaHorbach commented 6 days ago

Oh Crup We forgot @hoangzinh 😅

@trjExpensify Could you please assign him as he reviewed this PR ?

trjExpensify commented 6 days ago

Done!

hoangzinh commented 3 days ago

Regression Test Proposal

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account
Connect your workspace to QBD

Sign-in on the account above
Go to the connected QBD Workspace -> Accounting
Click on "Advanced" menu under QBD connection
Verify that there are 2 toggle buttons "Auto-sync" and "Auto-create entities"
Verify that the toggles work correctly

Do we agree 👍 or 👎

trjExpensify commented 3 days ago

Ah, @lakchote will the QBD regression tests get added centrally once the project launches?

Payment summary as follows:

$250 to @hoangzinh for the C+ review (go ahead and request)
$250 to @ZhenjaHorbach for the fix (offer sent!)

hoangzinh commented 2 days ago

Thanks @trjExpensify. I submitted an expense in ND.

lakchote commented 2 days ago

Ah, @lakchote will the QBD regression tests get added centrally once the project launches?

Yes an issue has been created for it.

garrettmknight commented 2 days ago

$250 approved fro @hoangzinh

trjExpensify commented 2 days ago

Perfect. Paid @ZhenjaHorbach, closing!

melvin-bot[bot] commented 2 days ago

@trjExpensify @lakchote Be sure to fill out the Contact List!