Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.58k stars 2.92k forks source link

[Create Money Request] Update iouReport optimistically #49717

Open grgia opened 2 months ago

grgia commented 2 months ago

Context

Follow up to https://github.com/Expensify/App/pull/49172

Reported here: https://github.com/Expensify/App/pull/49172#issuecomment-2374163798

Steps Taken

MULTI TRANSACTIONS FROM DIFFERENT USERS (IOU) AVATAR CASE

Log into user B in a separate session
Send a money request from user B
Verify that report preview avatar is both avatars, user A and B
Verify that report preview title is &
Both preview avatar and title are incorrect.

Expected Result: Report preview avatar is both avatars, user A and B

Actual Result: Report preview avatar is still only user A until refresh

Video

https://github.com/user-attachments/assets/077ef9ff-1a99-484b-95bc-6322990c18e3

https://github.com/user-attachments/assets/c948febf-3340-4c57-a297-065681d62588

Solution

I think this is probably an issue with updating the iouReport data optimistically when the IOU is made. https://github.com/Expensify/App/blob/main/src/libs/actions/IOU.ts#L1998

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

mallenexpensify commented 2 months ago

Checking to see if this is same/similar to what Cole reported https://expensify.slack.com/archives/C01SKUP7QR0/p1727461394841889?thread_ts=1727360298.835599&cid=C01SKUP7QR0

melvin-bot[bot] commented 1 month ago

@mallenexpensify, @grgia, @eh2077 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 1 month ago

@mallenexpensify, @grgia, @eh2077 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

mallenexpensify commented 1 month ago

Throwing on #wave-collect cuz the other avatar-related issue was on the same. And.. the bug affects collect users. @grgia is working on avatars, few issues for 'em out there, bumping to weekly.

melvin-bot[bot] commented 1 month ago

@mallenexpensify @grgia @eh2077 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

grgia commented 1 month ago

not overdue, this is polish

mallenexpensify commented 1 month ago

@grgia is working on. Gonna drop in Quality project for now

grgia commented 4 weeks ago

I haven't jumped back into this as I was working on some higher priority quality issues, but still planning to look into a solution here

mallenexpensify commented 3 weeks ago

I'm back from OOO on Nov 14th, not assigning another BZ because it's working being worked on internally and payment won't be due til after I'm back. If one is needed please add or post in #contributor-plus to ask for one to be added, thx.

grgia commented 1 week ago

Yeah I haven't had a chance to take this, I think I may unassign for now if we still think we should fix this

mallenexpensify commented 1 week ago

@grgia , this needs to be Internal, right? It looks like it's Medium for #quality so it might fall into the bucket of not highest priority for you and others. It's not AutoAssignerNewDotQuality so you can unassign if you don't think it's valuable to fix

grgia commented 6 days ago

@mallenexpensify yeah I'm not able to prioritize this right now, I'll label and unassign