search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.4k stars 2.79k forks source link

Tax - Tax rate is displayed but tax amount is shown zero #49784

Open lanitochka17 opened 6 days ago

lanitochka17 commented 6 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.40-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5010960 Issue reported by: Applause - Internal Team

Action Performed:

  1. In Android app, As admin set workspace currency default to 5%

  2. Distance rate - settings - toggle on track tax

  3. Open distance rate - set tax rate as 5%

  4. Go to https://staging.new.expensify.com/home

  5. Open employee workspace chat

  6. Tap plus icon near compose

  7. Create a distance expense by entering two different points

  8. Tap next

  9. Note tax amount

Expected Result:

Note tax rate is displayed but tax amount must not be shown as zero

Actual Result:

Note tax rate is displayed but tax amount is shown zero

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/c000576a-4339-4563-9715-48074c5639d8

View all open jobs on GitHub

melvin-bot[bot] commented 6 days ago

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

mkzie2 commented 5 days ago

I think this is expected because tax reclaimable value is not set. In other words, both tax rate and tax reclaimable value must be set to calculate the tax amount.

Screenshot 2024-09-27 at 17 12 59

Otherwise we can make the Tax reclaimable on field required when any Tax rate is selected to indicate the above constraint.

melvin-bot[bot] commented 1 day ago

@muttmuure Eep! 4 days overdue now. Issues have feelings too...