[$250] Unable to resolve duplicates on one-expense reporrts

m-natarajan commented 4 days ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.40-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @JmillsExpensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727339112704349

Action Performed:

Create a new workspace, upgrade to Control
Make sure you’re on the duplicate detection beta
Enabled delayed submission with a weekly frequency. Enable approvals (with you as the approver)
Have user a submit a report, with the merchant McDonalds for $50. Approve the report
Have the user create another expense report for the same merchant and amount (McDonalds and $50)
Have the user submit the report
Expected Result:

The approver is able to resolve a duplicate

Actual Result:

The approver is unable to resolve the duplicate, as no resolve duplicate button appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?
- [x] Android: Native
- [x] Android: mWeb Chrome
- [x] iOS: Native
- [x] iOS: mWeb Safari
- [x] MacOS: Chrome / Safari
- [x] MacOS: Desktop

Screenshots/Videos

CleanShot 2024-09-26 at 10 21 23@2x

Snip - (4) New Expensify - Google Chrome

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021839321413603387914
Upwork Job ID: 1839321413603387914
Last Price Increase: 2024-09-26

Issue Owner

Current Issue Owner: @sobitneupane

melvin-bot[bot] commented 4 days ago

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

daledah commented 4 days ago

Edited by proposal-police: This proposal was edited at 2024-09-26 15:28:39 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The approver is unable to resolve the duplicate, as no resolve duplicate button appears

What is the root cause of that problem?

New feature

What changes do you think we should make in order to solve the problem?

Create the function to detect if the expense report has the duplicate

function getDuplicatedReportID(reportID: string){
    return Object.values(allReportActions?.[`reportActions_${reportID}`] ?? {}).find(action=>{
        const transactionID = ReportActionsUtils.isMoneyRequestAction(action) && ReportActionsUtils.getOriginalMessage(action)?.IOUTransactionID
        if(!transactionID){
            return false;
        }
        return TransactionUtils.isDuplicate(transactionID)
    })?.childReportID
}

In MoneyReportHeader get the duplicated report ID

    const duplicatedReportID = useMemo(()=>{
        return ReportUtils.getDuplicatedReportID(moneyRequestReport?.reportID ?? '')
    },[moneyRequestReport?.reportID])

And then show the Resolve duplicate button if duplicatedReportID is not undefined

                {duplicatedReportID && !shouldUseNarrowLayout && (
                        <Button
                            success
                            text='Resolve duplicates'
                            style={[styles.p0, styles.ml2]}
                            onPress={() => {
                                Navigation.navigate(ROUTES.TRANSACTION_DUPLICATE_REVIEW_PAGE.getRoute(duplicatedReportID, Navigation.getReportRHPActiveRoute()));
                            }}
                        />
                    )}