[$250] Invoicing verify that the user has the feature enabled on the page

[rezkiy37]

Part of the Invoicing payments project

Main issue: https://github.com/Expensify/Expensify/issues/382977 Project: https://github.com/orgs/Expensify/projects/114/views/3

Feature Description

To wrap WorkspacePageWithSections with AccessOrNotFoundWrapper to avoid giving access of the Invoice page to the user where areInvoicesEnabled is false.

Manual Test Steps

Automated Tests

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021839691254986841972
• Upwork Job ID: 1839691254986841972
• Last Price Increase: 2024-09-27

Issue Owner

Current Issue Owner: @rezkiy37

[melvin-bot[bot]]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[rezkiy37]

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021839691254986841972

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[Pujan92]

Not sure whether I need to review this PR or not as it has been noticed here while reviewing other PR.

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

To wrap WorkspacePageWithSections with AccessOrNotFoundWrapper to avoid giving access of the Invoice page to the user where areInvoicesEnabled is false.

What is the root cause of that problem?

• On WorkspaceInvoicesPage - WorkspacePageWithSections is not wrapped with AccessOrNotFoundWrapper.

  What changes do you think we should make in order to solve the problem?

• On WorkspaceInvoicesPage - wrap WorkspacePageWithSections with AccessOrNotFoundWrapper.

      <AccessOrNotFoundWrapper
          accessVariants={[CONST.POLICY.ACCESS_VARIANTS.ADMIN, CONST.POLICY.ACCESS_VARIANTS.PAID]}
          policyID={route.params.policyID}
          featureName={CONST.POLICY.MORE_FEATURES.ARE_INVOICES_ENABLED}
      >
          <WorkspacePageWithSections
              ...
          </WorkspacePageWithSections>
      </AccessOrNotFoundWrapper>

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[rezkiy37]

@ChavdaSachin, I've already started to work on the issue - https://github.com/Expensify/App/issues/49842#issuecomment-2379204621. Moreover, I have a draft PR (https://github.com/Expensify/App/pull/49843). Going to open it soon 🙂