search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

`createPrerelease` is run and fails when a deploy is canceled due to `cancel-in-progress` #49851

Closed AndrewGable closed 1 month ago

AndrewGable commented 1 month ago

Problem

We had a deploy error on https://github.com/Expensify/App/actions/runs/11074305525/job/30773368164 because the build was canceled due to cancel-in-progress flag.

Solution

@roryabraham says:

I'd say this is expected - the deploy completed on at least one platform (web), so it creates the prerelease. I think we should just continue-on-error with these non-critical artifact upload steps

roryabraham commented 1 month ago

Going to just create a quick PR

roryabraham commented 1 month ago

Should be fixed by https://github.com/Expensify/App/pull/49852. We don't have a great way to test this per-se so I'm going to optimistically close it and we can monitor/reopen if we see it happen again.