[HOLD for payment 2024-10-10] [$250] [Search v2.1] Web - Search - App returns to Inbox after closing receipt view in Search

lanitochka17 commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.41-2 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to workspace chat
Submit an expense with receipt
Go to Search
Click on the expense submitted in Step 3
Click on the receipt
Click X button

Expected Result:

App will return to search page with transaction thread RHP open

Actual Result:

App returns to transaction thread in Inbox

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/bfab707e-d287-4c25-bd04-bf07fdb540cb

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021840734855215732913
Upwork Job ID: 1840734855215732913
Last Price Increase: 2024-09-30

Issue Owner

Current Issue Owner: @

github-actions[bot] commented 1 month ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

lanitochka17 commented 1 month ago

Production:

https://github.com/user-attachments/assets/d33b1bf9-84d3-43d6-87c0-4a24fc11e9af

lanitochka17 commented 1 month ago

We think that this bug might be related to #wave-control

Nodebrute commented 1 month ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

App returns to Inbox after closing receipt view in Search

What is the root cause of that problem?

We are dismissing modal here https://github.com/Expensify/App/blob/71db3f19691069182447b6b1b9fff62ec93be86c/src/pages/TransactionReceiptPage.tsx#L61-L63

What changes do you think we should make in order to solve the problem?

We should use Navigation.goBack instead. We can do something like this

  Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(report?.reportID ?? '-1'));

https://github.com/Expensify/App/blob/71db3f19691069182447b6b1b9fff62ec93be86c/src/pages/TransactionReceiptPage.tsx#L61-L63

What alternative solutions did you explore? (Optional)

rijusougata13 commented 1 month ago

Contributor details Your Expensify account email: rijusougata13@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~014959001a9ba2085d

melvin-bot[bot] commented 1 month ago

📣 @rijusougata13! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:
```
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
```

sumairq commented 1 month ago

Edited by proposal-police: This proposal was edited at 2024-09-28 23:05:57 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App returns to Inbox after closing receipt view in Search

What is the root cause of that problem?

We are dismissing modal here whereas we just need to close the open reciept and use a general purpose function .

https://github.com/Expensify/App/blob/71db3f19691069182447b6b1b9fff62ec93be86c/src/pages/TransactionReceiptPage.tsx#L61-L63

What changes do you think we should make in order to solve the problem?

We should use Navigation.goBack instead. We can do something like this

 onModalClose={() => { 
     Navigation.goBack(); 
 }}

Video

https://github.com/user-attachments/assets/9977c4b7-3ee5-4553-8ccd-7c6fcca5304d

What alternative solutions did you explore? (Optional)

github-actions[bot] commented 1 month ago

thouwhaleu Your proposal will be dismissed because you did not follow the proposal template.

Kicu commented 1 month ago

hey, I work for an expert agency and I would like to work on this issue. I have a lot of context since I worked on search a lot.

Kicu commented 1 month ago

@luacmartins you can assign me, I have a bit of time while waiting on other open Search PRs to merge

luacmartins commented 1 month ago

Thanks @Kicu! Demoting to NAB as well since this bug doesn't really break any functionality

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~021840734855215732913

melvin-bot[bot] commented 1 month ago

Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

Kicu commented 1 month ago

PR ready https://github.com/Expensify/App/pull/49915. I have not used any of the proposed suggestions, simply using goBack() might've broken some existing cases.

rayane-djouah commented 1 month ago

PR on staging

melvin-bot[bot] commented 1 month ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.43-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/49915

If no regressions arise, payment will be issued on 2024-10-10. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@Kicu does not require payment (Contractor)
@rayane-djouah requires payment (Needs manual offer from BZ)

rayane-djouah commented 1 month ago

BugZero Checklist

[x] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/49750
[x] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/49750/files#r1789280972
[x] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[x] Determine if we should create a regression test for this bug. Yes
[x] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Go to workspace chat.
Submit an expense with a receipt.
Navigate to the Search page.
Click on the submitted expense.
Click on the receipt within the transaction.
Click on the "X" close button to close the receipt view.
Verify that the app returns to the search page with the transaction thread in the right-hand panel (RHP) open.

Do we agree 👍 or 👎

rayane-djouah commented 1 month ago

@luacmartins could you please add the Bug label? Thanks!

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 month ago

Payment Summary

Upwork Job

Contributor: @Kicu is from an agency-contributor and not due payment
ROLE: @rayane-djouah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@zanyrenney)

[ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
[ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1840734855215732913/hired)
[ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
[ ] I have verified the payment summary above is correct

zanyrenney commented 1 month ago

bump @rayane-djouah can you apply to the job please? https://www.upwork.com/jobs/~021840734855215732913

rayane-djouah commented 1 month ago

@zanyrenney - Applied https://www.upwork.com/nx/proposals/1845826586166595585

zanyrenney commented 1 month ago

Payment Summary

Upwork Job

Contributor: @Kicu is from an agency-contributor and not due payment - ✅
ROLE: @rayane-djouah paid $(AMOUNT) via Upwork (LINK) paid $250 via upwork ✅

Expensify / App