[$125] [Search v2.3] IOS - Emoji is cut off in the dropdown button

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.41-2 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• There is at least one saved search
  1. Launch New Expensify app
  2. Go to Search
  3. Tap on the dropdown button
  4. Tap 3-dot menu next to the saved search
  5. Tap Rename
  6. Enter an emoji and save it
  7. Dismiss the dropdown modal

Expected Result:

The emoji will not be cut off in the dropdown button

Actual Result:

The emoji is cut off in the dropdown button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [x] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/44146f16-1207-4e7a-99eb-1b23098f749f

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021840184545557049275
• Upwork Job ID: 1840184545557049275
• Last Price Increase: 2024-09-29
• Automatic offers:
• ahmedGaber93 | Reviewer | 104219452
• Nodebrute | Contributor | 104219453

Issue Owner

Current Issue Owner: @ahmedGaber93

[melvin-bot[bot]]

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

Production:

https://github.com/user-attachments/assets/1d2fac2a-988a-4315-b9c8-0991ec2e546e

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-09-28 19:37:50 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emoji is cut off in the dropdown button

What is the root cause of that problem?

We recently enabled users to add emojis to saved search names, but we didn't update the styles of the Text component to support emojis. https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/pages/Search/SearchTypeMenuNarrow.tsx#L158-L163

What changes do you think we should make in order to solve the problem?

We should also add styles of lineHeight: variables.lineHeightLarge to this text component https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/pages/Search/SearchTypeMenuNarrow.tsx#L158-L163

Solution 1

          style={[styles.textStrong, styles.flexShrink1, styles.label]}

Solution 2

                                style={[styles.textStrong, styles.flexShrink1, styles.fontSizeLabel, styles.lineHeightLarge]}

Other minor styles can be adjusted in the PR

What alternative solutions did you explore? (Optional)

We can also use styles.textLineHeightNormal here

                                style={[styles.textStrong, styles.flexShrink1, styles.fontSizeLabel,styles.textLineHeightNormal]}

Alternative solution 2 We can add the lineheight styles according to the design.

[roryabraham]

Issue stemming from https://github.com/Expensify/App/pull/49528, but NAB and not worth reverting imo

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021840184545557049275

[melvin-bot[bot]]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[melvin-bot[bot]]

Triggered auto assignment to @dannymcclain (Design), see these Stack Overflow questions for more details.

[melvin-bot[bot]]

Upwork job price has been updated to $125

[roryabraham]

I think that @Nodebrute's proposal looks reasonable, but want @dannymcclain to double-check first

[Krishna2323]

Proposal


Please re-state the problem that we are trying to solve in this issue.

IOS - Saved search - Emoji is cut off in the dropdown button

What is the root cause of that problem?

• We haven't added the correct line height to the text element.

https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/pages/Search/SearchTypeMenuNarrow.tsx#L158-L163

What changes do you think we should make in order to solve the problem?


• First we should check if the menuTitle includes an emoji or not. We can do it similarly as we do in WrappedText. https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/components/InlineCodeBlock/WrappedText.tsx#L36-L41

const hasEmoji = useMemo(() => containsEmoji(menuTitle), [menuTitle]);

• If hasEmoji is true we will apply hasEmoji && styles.codeTextStyle. codeTextStyle has line height according to the platform. https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/styles/utils/codeStyles/index.ts#L6 https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/styles/utils/codeStyles/index.ios.ts#L13-L15 https://github.com/Expensify/App/blob/3047c1baa21f47825f5c1ffd652184341dd22256/src/styles/utils/codeStyles/index.android.ts#L12-L14
• We should test on all platforms and if codeTextStyle isn't perfect, we can create new styles according to the platforms.

What alternative solutions did you explore? (Optional)

Result

[Kicu]

The solution presented by @Nodebrute seems legit but I would suggest one small improvement.

I can see that we have a dedicated style called label here: https://github.com/Expensify/App/blob/d47e1562fa6adb9968623512ee59af0fa6a4acba/src/styles/index.ts#L371 and it is defined like this:

label: {
      fontSize: variables.fontSizeLabel,
      lineHeight: variables.lineHeightLarge,
}

That tells me we do want this specific lineHeightLarge combined with fontSizeLabel. So I think instead of directly adding lineHeightLarge in the component we should just use styles.label. This style is used in multiple other places as well.

[dannymcclain]

Solution seems reasonable to me.

As a side note: I think we need to add the clear / circle-x button to that name field so people can clear it out quickly and easily (like we do with Group names): Obviously that doesn't need to be part of this issue, just making a note here so I don't forget 😂 cc @dubielzyk-expensify

[Muhammad-Maraj-Khan]

The solution also seems good for me.

[melvin-bot[bot]]

📣 @Muhammad-Maraj-Khan! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:

   Contributor details
   Your Expensify account email: <REPLACE EMAIL HERE>
   Upwork Profile Link: <REPLACE LINK HERE>

[Muhammad-Maraj-Khan]

Contributor details Your Expensify account email: mairajkhan11345@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~01fdb5331a4bc5b415

[melvin-bot[bot]]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[Nodebrute]

@roryabraham Can you assign this to me? Just a suggestion: could you increase the price? I can also implement this. https://github.com/Expensify/App/issues/49890#issuecomment-2383200176

[roryabraham]

Awaiting 👍🏼 from @ahmedGaber93 since he'll have to review the PR. I set the price lower because this seems like a very simple issue and it affects only one platform.

[ahmedGaber93]

@Nodebrute's proposal LGTM! And works fine on other platforms

🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Current assignee @roryabraham is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[ahmedGaber93]

Do we solve this https://github.com/Expensify/App/issues/49890#issuecomment-2383200176 here too? If yes, we can handle it in the PR.

[dannymcclain]

Do we solve this https://github.com/Expensify/App/issues/49890#issuecomment-2383200176 here too? If yes, we can handle it in the PR.

I'll let @roryabraham weigh in on that one/decide—it's pretty unrelated but if it's a super simple update it'd be nice to get it knocked out.

[roryabraham]

Do we solve this https://github.com/Expensify/App/issues/49890#issuecomment-2383200176 here too? If yes, we can handle it in the PR.

Nah, let's do a separate issue for that. @dannymcclain can you create it, and label it Bug, External plz?

[melvin-bot[bot]]

📣 @ahmedGaber93 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @Nodebrute 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[Nodebrute]

I'll raise the pr in few hours.