search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[$250] mWeb - Dupe detection - Multiple "resolved the duplicate" message is created #49900

Closed lanitochka17 closed 1 month ago

lanitochka17 commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.41-2 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+ds@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

  1. [Employee] Submit two expenses that are duplicated
  2. [Admin] Go to the transaction thread of a transaction
  3. [Admin] Review the duplicate and chose any transaction to keep
  4. [Admin] Confirm to resolve the duplicate
  5. Admin] Click the Back button, notice you are returned to "Review duplicates" page
  6. Admin] Click on "confirm"

Expected Result:

Clicking the Back button does not take to "Review duplicates" page

Actual Result:

Clicking the Back button takes you back to "Review duplicates" page. And confirming creates multiple "resolved the duplicate" and "Held this Expense" messages in the report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/445563f3-4abf-4287-8381-0502a0debd47

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021840789692182968366
  • Upwork Job ID: 1840789692182968366
  • Last Price Increase: 2024-09-30
Issue OwnerCurrent Issue Owner: @dukenv0307
github-actions[bot] commented 1 month ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Gonals commented 1 month ago

Only happening in one platform, so not a Web-E blocker

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~021840789692182968366

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

neil-marcellini commented 1 month ago

This is also reproducible on Mac Chrome on a small screen

https://github.com/user-attachments/assets/1cb71b75-e249-4d3e-a28e-d62af176fa5a

jasperhuangg commented 1 month ago

This was fixed in https://github.com/Expensify/App/pull/49953