Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[$250] Deeplink - Infinite loading displayed when clicked on open in app button #49902

Closed lanitochka17 closed 1 week ago

lanitochka17 commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.41-2 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5016926 Email or phone of affected tester (no customers): rybkina@gmail.com, rybkina+092024@gmail.com Issue reported by: Applause - Internal Team

Action Performed:

  1. Sign in with account A in desktop app and account B in web
  2. Open staging.new.expensify.com in web any chat
  3. Reload the page
  4. Click on button "Open New Expensify" on pop-up "Open New Expensify?"

Expected Result:

Chat selected on step 2 should be open after redirected to desktop app and signed in with account B

Actual Result:

Infinite loading displayed when user redirected to the desktop app. But seeting page shown all info about user B

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/76c8dfab-f394-4bd4-b7cf-13712e0c633c

54 40

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021846257436627573924
  • Upwork Job ID: 1846257436627573924
  • Last Price Increase: 2024-11-05
Issue OwnerCurrent Issue Owner: @rayane-djouah
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @MarioExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 1 month ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
Gonals commented 1 month ago

@lanitochka17, can this be consistently reproduced?

Gonals commented 1 month ago

Seems to be frontend, so removing Web-E blocker

MarioExpensify commented 1 month ago

Checking frontend

MarioExpensify commented 1 month ago

I was able to reproduce it in staging, trying to debug and check latest commits to find out what happened

MarioExpensify commented 1 month ago

As this seem to be an edge case (multiple logins being switched through web and desktop apps) caused by a frontend change, I'll investigate it further and take action accordingly. Meanwhile I'm removing the DeployBlocker for the app.

MarioExpensify commented 1 month ago

Still looking into this

MarioExpensify commented 1 month ago

Making this external.

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~021846257436627573924

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

rayane-djouah commented 1 month ago

Waiting on proposals

rayane-djouah commented 1 month ago

@MarioExpensify Could you please assign a BZ member?

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

rayane-djouah commented 4 weeks ago

Waiting on proposals

melvin-bot[bot] commented 3 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

rayane-djouah commented 3 weeks ago

Waiting on proposals

melvin-bot[bot] commented 3 weeks ago

@RachCHopkins, @rayane-djouah, @MarioExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

rayane-djouah commented 3 weeks ago

Waiting on proposals

melvin-bot[bot] commented 3 weeks ago

@RachCHopkins @rayane-djouah @MarioExpensify this issue is now 4 weeks old, please consider:

Thanks!

NJ-2020 commented 2 weeks ago

I cannot reproduce this issue @rayane-djouah Did you still able to reproduce this issue? Thanks

rayane-djouah commented 2 weeks ago

Let me try reproducing it once more

melvin-bot[bot] commented 2 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

MarioExpensify commented 2 weeks ago

@rayane-djouah let us know if this still happens, if not I'll close the issue.

mvtglobally commented 2 weeks ago

Issue not reproducible during KI retests. (First week)

MarioExpensify commented 2 weeks ago

Changing it to weekly, let's reevaluate next week and if we still can't reproduce we'll close this. Thanks @mvtglobally

NJ-2020 commented 2 weeks ago

I can reproduce this issue when i try to login from OD and then got redirected to ND

https://github.com/user-attachments/assets/2f496ff3-2064-45a3-a54a-3554c533a21a

melvin-bot[bot] commented 1 week ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

MarioExpensify commented 1 week ago

Thanks @NJ-2020, I tried the same steps as you documented and now I have no luck trying to reproduce. It seems a pretty specific sequence that is causing the issue. @RachCHopkins do you have any thoughts on this issue?

RachCHopkins commented 1 week ago

@MarioExpensify I have none. I think if we can't repro it consistently let's close it.

MarioExpensify commented 1 week ago

Thanks for your input @RachCHopkins, I'll close it and we may reopen if needed. I just tried it again (both the original post and @NJ-2020) with no luck.

melvin-bot[bot] commented 1 week ago

@RachCHopkins @MarioExpensify Be sure to fill out the Contact List!