Open lanitochka17 opened 3 weeks ago
Triggered auto assignment to @trjExpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Triggered auto assignment to @lakchote (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
I think we can demote this to NAB
Hi, I'm Tymoteusz from Software Mansion and I worked on search-related issues before, I will gladly work on this one.
Would we want to scroll to the exact same position or would scrolling to the selected chat report be sufficient?
I think we'd want to scroll to the selected message
Not overdue @cdOut is working on this.
@cdOut any updates?
@lakchote, @cdOut Whoops! This issue is 2 days overdue. Let's get this updated quick!
I'm working on a draft PR, should have a working POC by the end of the week. We were slightly concerned about handling the case where you might lose the saved search data after reloading, in which you wouldn't be able to scroll back to it, so I'm trying to see whether and when that could possibly happen here.
@cdOut how is it going?
Sorry for the late update, I've had to go back to my other ongoing issues with Guided Setup that have higher prio after some backend changes were merged for them. I'll update later today or early tomorrow with the state of the PR for this issue.
@cdOut friendly bump
Here's the update, I've created a POC to check whether to only utilize the selected message link id or to save the offset in session storage. I'm currently testing whether we don't have any possible situations where we lose the saved onyx search data after reload so we wouldn't be able to scroll to an unloaded item. Will report back tomorrow.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.41 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Issue found when executing PR https://github.com/Expensify/App/pull/49641
Action Performed:
Expected Result:
The app goes back to the message I tapped on before
Actual Result:
The app redirects to the top of messages instead of returning to the previously selected message
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/d5a247e4-ab36-4385-b460-a20241537f84
View all open jobs on GitHub