search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.48k stars 2.83k forks source link

Workspace - Duplicate expense preview avatar after workspace is deleted #49927

Open lanitochka17 opened 2 weeks ago

lanitochka17 commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.41-2 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new workspace
  3. Submit an expense
  4. Delete the workspace
  5. Go to the workspace chat (now archived)

Expected Result:

The expense preview avatar will remain the same after the workspace is deleted

Actual Result:

The expense preview avatar changes after the workspace is deleted It changes to stacked avatars with both avatars from the workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/f6a48007-9caa-4421-a435-4eb8ee84e876

View all open jobs on GitHub

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 2 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 2 weeks ago

Current assignee @mjasikowski is eligible for the DeployBlockerCash assigner, not assigning anyone new.

github-actions[bot] commented 2 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
mjasikowski commented 2 weeks ago

Possibly related: https://github.com/Expensify/App/pull/49403

mjasikowski commented 2 weeks ago

Reverting https://github.com/Expensify/App/pull/49403 did not fix the issue, looking further

mjasikowski commented 2 weeks ago

Pinpointed the offending PR using git bisect: https://github.com/Expensify/App/pull/49172

mjasikowski commented 2 weeks ago

@grgia would you be able to take a look at this and see if this can be easily fixed or reverted?

grgia commented 2 weeks ago

It's late for me let's revert https://github.com/Expensify/App/pull/49172 for now

jasperhuangg commented 2 weeks ago

We reverted the problematic PR https://github.com/Expensify/App/pull/49945. Gonna remove the label but keep this open so @grgia can fix this in a followup.

melvin-bot[bot] commented 2 weeks ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 2 weeks ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.