iOS Search - Rename page opens twice when renaming search and opening Rename page again

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.41-3 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User has saved search
  1. Launch New Expensify app
  2. Go to Search
  3. Tap on the dropdown
  4. Tap 3-dot menu next to the saved search
  5. Tap Rename
  6. Rename and save it
  7. Tap on the dropdown
  8. Tap 3-dot menu next to the saved search
  9. Tap Rename

Expected Result:

Rename page will open once

Actual Result:

Rename page opens twice. Another one is in the background of the current Rename page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/22d7969e-157b-401a-af1a-4d8b5495ac08

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-control

[drminh2807]

Edited by proposal-police: This proposal was edited at 2024-09-30 16:24:52 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS Search - Rename page opens twice when renaming search and opening Rename page again

What is the root cause of that problem?

We haven't dismiss modal yet

What changes do you think we should make in order to solve the problem?

Add Navigation.dismissModal(); in https://github.com/Expensify/App/blob/main/src/pages/Search/SavedSearchRenamePage.tsx#L27-L34

What alternative solutions did you explore? (Optional)

N/A

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Rename page opens twice when renaming search and opening Rename page again

What is the root cause of that problem?

We are not dismissing the modal while navigating to central pane here https://github.com/Expensify/App/blob/a9224f30ef9643644d20a90bc4488371c5f542ff/src/pages/Search/SavedSearchRenamePage.tsx#L28-L33

What changes do you think we should make in order to solve the problem?

We can add Navigation.dismissModal() here https://github.com/Expensify/App/blob/a9224f30ef9643644d20a90bc4488371c5f542ff/src/pages/Search/SavedSearchRenamePage.tsx#L28-L33

   const applyFiltersAndNavigate = () => {
        SearchActions.clearAdvancedFilters();
        Navigation.dismissModal();
        Navigation.navigate(
            ROUTES.SEARCH_CENTRAL_PANE.getRoute({
                query: q,
                name: newName,
            }),
        );
    };

What alternative solutions did you explore? (Optional)

[github-actions[bot]]

@user Your proposal will be dismissed because you did not follow the proposal template.

[Nodebrute]

Note for C+ we both posted the proposal in almost the same second and this is @drminh2807's proposal before edits