[$250] After hold and unhold expense page is not scrolling down to comments section

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.41-6 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @dukenv0307 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727724158339229

Action Performed:

1. Go to a workspace
2. Submit an expense
3. Go to the expense detail page and click on the header
4. Hold this expense
5. Unhold this expense

   Expected Result:

   After hold and unhold expense, it is scroll to bottom

   Actual Result:

   After hold and unhold expense, it isn't scrolling to the comment section

   Workaround:

   Unknown

   Platforms:

   Which of our officially supported platforms is this issue occurring on?

   • [ ] Android: Native
   • [ ] Android: mWeb Chrome
   • [ ] iOS: Native
   • [ ] iOS: mWeb Safari
   • [x] MacOS: Chrome / Safari
   • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/398342a7-aaad-495f-9737-de73d1e94378

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021841168390578719829
• Upwork Job ID: 1841168390578719829
• Last Price Increase: 2024-10-29
• Automatic offers:
• dukenv0307 | Reviewer | 104747445
• nkdengineer | Contributor | 104747448

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @dukenv0307

[dukenv0307]

Still waiting for more proposals...

[Anaslancer]

@dukenv0307 Finally I found the solution without changing the useEffect logic. We should use notifyNewAction at the end of putOnHold and unholdRequest. but we should send correct params for this.

const report = ReportUtils.getReport(reportID);
Report.notifyNewAction(report?.parentReportID ?? '-1', createdReportAction.actorAccountID);

[Anaslancer]

Proposal

Updated

[Anaslancer]

https://github.com/user-attachments/assets/c31bd6b1-e8e3-4a62-b1c7-89b5f6968d3d

[nkdengineer]

It seems that in this PR it changed the condition to calculate hasNewestReportAction and it also solves the problem in with one transaction thread @dukenv0307 please check my proposal again

[dukenv0307]

@nkdengineer's proposal looks good to me. @Anaslancer Your solution is quite same as @nkdengineer, but it doesn't fix the case there're more than 1 money request

🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @mjasikowski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mjasikowski]

let's go with @nkdengineer's proposal!

[melvin-bot[bot]]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖